diff options
| author | zsxwing <zsxwing@gmail.com> | 2015-07-15 17:30:57 +0900 |
|---|---|---|
| committer | Kousuke Saruta <sarutak@oss.nttdata.co.jp> | 2015-07-15 17:30:57 +0900 |
| commit | adb33d3665770daf2ccb8915d19e198be9dc3b47 (patch) | |
| tree | a9a9c45a332da660ad9d8bdcddcbcdc159fae205 /core | |
| parent | 14935d846a4f6bcd4d2a448a8f112fa5dee769ba (diff) | |
| download | spark-adb33d3665770daf2ccb8915d19e198be9dc3b47.tar.gz spark-adb33d3665770daf2ccb8915d19e198be9dc3b47.tar.bz2 spark-adb33d3665770daf2ccb8915d19e198be9dc3b47.zip | |
[SPARK-9012] [WEBUI] Escape Accumulators in the task table
If running the following codes, the task table will be broken because accumulators aren't escaped.
```
val a = sc.accumulator(1, "<table>")
sc.parallelize(1 to 10).foreach(i => a += i)
```
Before this fix,
<img width="1348" alt="screen shot 2015-07-13 at 8 02 44 pm" src="https://cloud.githubusercontent.com/assets/1000778/8649295/b17c491e-299b-11e5-97ee-4e6a64074c4f.png">
After this fix,
<img width="1355" alt="screen shot 2015-07-13 at 8 14 32 pm" src="https://cloud.githubusercontent.com/assets/1000778/8649337/f9e9c9ec-299b-11e5-927e-35c0a2f897f5.png">
Author: zsxwing <zsxwing@gmail.com>
Closes #7369 from zsxwing/SPARK-9012 and squashes the following commits:
a83c9b6 [zsxwing] Escape Accumulators in the task table
Diffstat (limited to 'core')
| -rw-r--r-- | core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala index ff0a339a39..27b82aaddd 100644 --- a/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala +++ b/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala @@ -692,7 +692,9 @@ private[ui] class StagePage(parent: StagesTab) extends WebUIPage("stage") { val gettingResultTime = getGettingResultTime(info, currentTime) val maybeAccumulators = info.accumulables - val accumulatorsReadable = maybeAccumulators.map{acc => s"${acc.name}: ${acc.update.get}"} + val accumulatorsReadable = maybeAccumulators.map { acc => + StringEscapeUtils.escapeHtml4(s"${acc.name}: ${acc.update.get}") + } val maybeInput = metrics.flatMap(_.inputMetrics) val inputSortable = maybeInput.map(_.bytesRead.toString).getOrElse("") |