diff options
| author | Patrick Wendell <pwendell@gmail.com> | 2013-10-22 10:37:09 -0700 |
|---|---|---|
| committer | Patrick Wendell <pwendell@gmail.com> | 2013-10-22 11:00:50 -0700 |
| commit | c22046b3cc740733b86ddf6daa638de447c32c73 (patch) | |
| tree | 55e4f40f1cf918e569174377a466955aebf6cc82 /core | |
| parent | 7de0ea4d426e9964dee8173c7dca19601ad0f4b1 (diff) | |
| download | spark-c22046b3cc740733b86ddf6daa638de447c32c73.tar.gz spark-c22046b3cc740733b86ddf6daa638de447c32c73.tar.bz2 spark-c22046b3cc740733b86ddf6daa638de447c32c73.zip | |
Minor clean-up in review
Diffstat (limited to 'core')
3 files changed, 3 insertions, 8 deletions
diff --git a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala index ff68255583..dda194d953 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala @@ -608,7 +608,6 @@ class DAGScheduler( logDebug("New pending tasks: " + myPending) taskSched.submitTasks( new TaskSet(tasks.toArray, stage.id, stage.newAttemptId(), stage.jobId, properties)) - stage.submissionTime = Some(System.currentTimeMillis()) stageToInfos(stage).submissionTime = Some(System.currentTimeMillis()) } else { logDebug("Stage " + stage + " is actually done; %b %d %d".format( @@ -631,9 +630,9 @@ class DAGScheduler( val stage = stageIdToStage(task.stageId) def markStageAsFinished(stage: Stage) = { - val serviceTime = stage.submissionTime match { + val serviceTime = stageToInfos(stage).submissionTime match { case Some(t) => "%.03f".format((System.currentTimeMillis() - t) / 1000.0) - case _ => "Unkown" + case _ => "Unknown" } logInfo("%s (%s) finished in %s s".format(stage, stage.name, serviceTime)) stageToInfos(stage).completionTime = Some(System.currentTimeMillis()) diff --git a/core/src/main/scala/org/apache/spark/scheduler/Stage.scala b/core/src/main/scala/org/apache/spark/scheduler/Stage.scala index d06633d7d2..7cb3fe46e5 100644 --- a/core/src/main/scala/org/apache/spark/scheduler/Stage.scala +++ b/core/src/main/scala/org/apache/spark/scheduler/Stage.scala @@ -50,10 +50,6 @@ private[spark] class Stage( val numPartitions = rdd.partitions.size val outputLocs = Array.fill[List[MapStatus]](numPartitions)(Nil) var numAvailableOutputs = 0 - - /** When this stage was submitted from the DAGScheduler to a TaskScheduler. */ - var submissionTime: Option[Long] = None - private var nextAttemptId = 0 def isAvailable: Boolean = { diff --git a/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala b/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala index 5ce92bc8d5..42ca988f7a 100644 --- a/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala +++ b/core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala @@ -18,7 +18,7 @@ package org.apache.spark.scheduler import org.scalatest.{BeforeAndAfter, FunSuite} -import org.apache.spark.{TaskContext, SparkContext, LocalSparkContext} +import org.apache.spark.{LocalSparkContext, SparkContext} import scala.collection.mutable import org.scalatest.matchers.ShouldMatchers import org.apache.spark.SparkContext._ |