diff options
author | Kousuke Saruta <sarutak@oss.nttdata.co.jp> | 2015-04-01 11:11:56 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2015-04-01 11:11:56 +0100 |
commit | d824c11c9fe8af1ca1d7c694b2fb81289eb83f97 (patch) | |
tree | c2b223a73e0825e9e420367e1d91cda9ef62057e /core | |
parent | 412262346f6f48e641bd6899c703efa31aeaba1e (diff) | |
download | spark-d824c11c9fe8af1ca1d7c694b2fb81289eb83f97.tar.gz spark-d824c11c9fe8af1ca1d7c694b2fb81289eb83f97.tar.bz2 spark-d824c11c9fe8af1ca1d7c694b2fb81289eb83f97.zip |
[SPARK-6597][Minor] Replace `input:checkbox` with `input[type="checkbox"]` in additional-metrics.js
In additional-metrics.js, there are some selector notation like `input:checkbox` but JQuery's official document says `input[type="checkbox"]` is better.
https://api.jquery.com/checkbox-selector/
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Closes #5254 from sarutak/SPARK-6597 and squashes the following commits:
a253bc4 [Kousuke Saruta] Replaced input:checkbox with input[type="checkbox"]
Diffstat (limited to 'core')
-rw-r--r-- | core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js index 14ba37d7c9..013db8df9b 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js +++ b/core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js @@ -30,7 +30,7 @@ $(function() { stripeSummaryTable(); - $("input:checkbox").click(function() { + $('input[type="checkbox"]').click(function() { var column = "table ." + $(this).attr("name"); $(column).toggle(); stripeSummaryTable(); @@ -39,15 +39,15 @@ $(function() { $("#select-all-metrics").click(function() { if (this.checked) { // Toggle all un-checked options. - $('input:checkbox:not(:checked)').trigger('click'); + $('input[type="checkbox"]:not(:checked)').trigger('click'); } else { // Toggle all checked options. - $('input:checkbox:checked').trigger('click'); + $('input[type="checkbox"]:checked').trigger('click'); } }); // Trigger a click on the checkbox if a user clicks the label next to it. $("span.additional-metric-title").click(function() { - $(this).parent().find('input:checkbox').trigger('click'); + $(this).parent().find('input[type="checkbox"]').trigger('click'); }); }); |