aboutsummaryrefslogtreecommitdiff
path: root/dev/run-tests
diff options
context:
space:
mode:
authorNicholas Chammas <nicholas.chammas@gmail.com>2014-09-19 15:44:47 -0700
committerMichael Armbrust <michael@databricks.com>2014-09-19 15:44:47 -0700
commit99b06b6fd2d79403ef4307ac6f3fa84176e7a622 (patch)
treecf532fb8463eb10ddbbb4727ec672edae123fecb /dev/run-tests
parentba68a51c407197d478b330403af8fe24a176bef3 (diff)
downloadspark-99b06b6fd2d79403ef4307ac6f3fa84176e7a622.tar.gz
spark-99b06b6fd2d79403ef4307ac6f3fa84176e7a622.tar.bz2
spark-99b06b6fd2d79403ef4307ac6f3fa84176e7a622.zip
[Build] Fix passing of args to sbt
Simple mistake, simple fix: ```shell args="arg1 arg2 arg3" sbt $args # sbt sees 3 arguments sbt "$args" # sbt sees 1 argument ``` Should fix the problems we are seeing [here](https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/694/AMPLAB_JENKINS_BUILD_PROFILE=hadoop1.0,label=centos/console), for example. Author: Nicholas Chammas <nicholas.chammas@gmail.com> Closes #2462 from nchammas/fix-sbt-master-build and squashes the following commits: 4500c86 [Nicholas Chammas] warn about quoting 10018a6 [Nicholas Chammas] Revert "test hadoop1 build" 7d5356c [Nicholas Chammas] Revert "re-add bad quoting for testing" 061600c [Nicholas Chammas] re-add bad quoting for testing b2de56c [Nicholas Chammas] test hadoop1 build 43fb854 [Nicholas Chammas] unquote profile args
Diffstat (limited to 'dev/run-tests')
-rwxr-xr-xdev/run-tests7
1 files changed, 6 insertions, 1 deletions
diff --git a/dev/run-tests b/dev/run-tests
index 5f6df17b50..c3d8f49cdd 100755
--- a/dev/run-tests
+++ b/dev/run-tests
@@ -127,6 +127,8 @@ echo "========================================================================="
# NOTE: echo "q" is needed because sbt on encountering a build file with failure
#+ (either resolution or compilation) prompts the user for input either q, r, etc
#+ to quit or retry. This echo is there to make it not block.
+ # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be interpreted as a
+ #+ single argument!
# QUESTION: Why doesn't 'yes "q"' work?
# QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
echo -e "q\n" \
@@ -159,10 +161,13 @@ echo "========================================================================="
# NOTE: echo "q" is needed because sbt on encountering a build file with failure
#+ (either resolution or compilation) prompts the user for input either q, r, etc
#+ to quit or retry. This echo is there to make it not block.
+ # NOTE: Do not quote $SBT_MAVEN_PROFILES_ARGS or else it will be interpreted as a
+ #+ single argument!
+ #+ "${SBT_MAVEN_TEST_ARGS[@]}" is cool because it's an array.
# QUESTION: Why doesn't 'yes "q"' work?
# QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
echo -e "q\n" \
- | sbt/sbt "$SBT_MAVEN_PROFILES_ARGS" "${SBT_MAVEN_TEST_ARGS[@]}" \
+ | sbt/sbt $SBT_MAVEN_PROFILES_ARGS "${SBT_MAVEN_TEST_ARGS[@]}" \
| grep -v -e "info.*Resolving" -e "warn.*Merging" -e "info.*Including"
}