diff options
| author | Josh Rosen <joshrosen@databricks.com> | 2016-03-07 21:50:01 -0800 |
|---|---|---|
| committer | Andrew Or <andrew@databricks.com> | 2016-03-07 21:50:01 -0800 |
| commit | e52e597db48d069b98c1d404b221d3365f38fbb8 (patch) | |
| tree | 4726833e40fca0e9aa9c265ea772afe5c81bdc7e /dev | |
| parent | 017cdf2be67776978a940609d610afea79856b17 (diff) | |
| download | spark-e52e597db48d069b98c1d404b221d3365f38fbb8.tar.gz spark-e52e597db48d069b98c1d404b221d3365f38fbb8.tar.bz2 spark-e52e597db48d069b98c1d404b221d3365f38fbb8.zip | |
[SPARK-13659] Refactor BlockStore put*() APIs to remove returnValues
In preparation for larger refactoring, this patch removes the confusing `returnValues` option from the BlockStore put() APIs: returning the value is only useful in one place (caching) and in other situations, such as block replication, it's simpler to put() and then get().
As part of this change, I needed to refactor `BlockManager.doPut()`'s block replication code. I also changed `doPut()` to access the memory and disk stores directly rather than calling them through the BlockStore interface; this is in anticipation of a followup patch to remove the BlockStore interface so that the disk store can expose a binary-data-oriented API which is not concerned with Java objects or serialization.
These changes should be covered by the existing storage unit tests. The best way to review this patch is probably to look at the individual commits, all of which are small and have useful descriptions to guide the review.
/cc davies for review.
Author: Josh Rosen <joshrosen@databricks.com>
Closes #11502 from JoshRosen/remove-returnvalues.
Diffstat (limited to 'dev')
0 files changed, 0 insertions, 0 deletions