aboutsummaryrefslogtreecommitdiff
path: root/dev
diff options
context:
space:
mode:
authorPrashant Sharma <prashant@apache.org>2014-09-15 21:14:00 -0700
committerReynold Xin <rxin@apache.org>2014-09-15 21:14:00 -0700
commitecf0c02935815f0d4018c0e30ec4c784e60a5db0 (patch)
tree67c6932a37eeb0b8fecb8566a73efd4c3b98c59e /dev
parentd428ac6a221d2dce19c43442abf197f2ade6658f (diff)
downloadspark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.tar.gz
spark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.tar.bz2
spark-ecf0c02935815f0d4018c0e30ec4c784e60a5db0.zip
[SPARK-3433][BUILD] Fix for Mima false-positives with @DeveloperAPI and @Experimental annotations.
Actually false positive reported was due to mima generator not picking up the new jars in presence of old jars(theoretically this should not have happened.). So as a workaround, ran them both separately and just append them together. Author: Prashant Sharma <prashant@apache.org> Author: Prashant Sharma <prashant.s@imaginea.com> Closes #2285 from ScrapCodes/mima-fix and squashes the following commits: 093c76f [Prashant Sharma] Update mima 59012a8 [Prashant Sharma] Update mima 35b6c71 [Prashant Sharma] SPARK-3433 Fix for Mima false-positives with @DeveloperAPI and @Experimental annotations.
Diffstat (limited to 'dev')
-rwxr-xr-xdev/mima8
1 files changed, 8 insertions, 0 deletions
diff --git a/dev/mima b/dev/mima
index f9b9b03538..40603166c2 100755
--- a/dev/mima
+++ b/dev/mima
@@ -25,11 +25,19 @@ FWDIR="$(cd "`dirname "$0"`"/..; pwd)"
cd "$FWDIR"
echo -e "q\n" | sbt/sbt oldDeps/update
+rm -f .generated-mima*
+
+# Generate Mima Ignore is called twice, first with latest built jars
+# on the classpath and then again with previous version jars on the classpath.
+# Because of a bug in GenerateMIMAIgnore that when old jars are ahead on classpath
+# it did not process the new classes (which are in assembly jar).
+./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
export SPARK_CLASSPATH="`find lib_managed \( -name '*spark*jar' -a -type f \) | tr "\\n" ":"`"
echo "SPARK_CLASSPATH=$SPARK_CLASSPATH"
./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore
+
echo -e "q\n" | sbt/sbt mima-report-binary-issues | grep -v -e "info.*Resolving"
ret_val=$?