diff options
| author | Reynold Xin <rxin@apache.org> | 2014-07-30 09:28:53 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@apache.org> | 2014-07-30 09:28:53 -0700 |
| commit | 3bc3f1801e3347e02cbecdd8e941003430155da2 (patch) | |
| tree | e0a9df74260a4d95abac4197393cd41a2fbf825e /dev | |
| parent | 774142f5556ac37fddf03cfa46eb23ca1bde2492 (diff) | |
| download | spark-3bc3f1801e3347e02cbecdd8e941003430155da2.tar.gz spark-3bc3f1801e3347e02cbecdd8e941003430155da2.tar.bz2 spark-3bc3f1801e3347e02cbecdd8e941003430155da2.zip | |
[SPARK-2747] git diff --dirstat can miss sql changes and not run Hive tests
dev/run-tests use "git diff --dirstat master" to check whether sql is changed. However, --dirstat won't show sql if sql's change is negligible (e.g. 1k loc change in core, and only 1 loc change in hive).
We should use "git diff --name-only master" instead.
Author: Reynold Xin <rxin@apache.org>
Closes #1656 from rxin/hiveTest and squashes the following commits:
f5eab9f [Reynold Xin] [SPARK-2747] git diff --dirstat can miss sql changes and not run Hive tests.
Diffstat (limited to 'dev')
| -rwxr-xr-x | dev/run-tests | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/dev/run-tests b/dev/run-tests index 98ec969dc1..795d16a4d9 100755 --- a/dev/run-tests +++ b/dev/run-tests @@ -37,7 +37,7 @@ JAVA_VERSION=$($java_cmd -version 2>&1 | sed 's/java version "\(.*\)\.\(.*\)\..* # Partial solution for SPARK-1455. Only run Hive tests if there are sql changes. if [ -n "$AMPLAB_JENKINS" ]; then git fetch origin master:master - diffs=`git diff --dirstat master | awk '{ print $2; }' | grep "^sql/"` + diffs=`git diff --name-only master | grep "^sql/"` if [ -n "$diffs" ]; then echo "Detected changes in SQL. Will run Hive test suite." export _RUN_SQL_TESTS=true # exported for PySpark tests |