diff options
author | Patrick Wendell <pwendell@gmail.com> | 2014-06-01 17:27:05 -0700 |
---|---|---|
committer | Reynold Xin <rxin@apache.org> | 2014-06-01 17:27:05 -0700 |
commit | d17d221487fa7a3af6f4af2217f1d4889ceb084d (patch) | |
tree | e54f3d7c4fa84e32a60f5fd5776672401f00929a /dev | |
parent | eea3aab4f29de5ee11670340245039f7395ab26e (diff) | |
download | spark-d17d221487fa7a3af6f4af2217f1d4889ceb084d.tar.gz spark-d17d221487fa7a3af6f4af2217f1d4889ceb084d.tar.bz2 spark-d17d221487fa7a3af6f4af2217f1d4889ceb084d.zip |
Better explanation for how to use MIMA excludes.
This patch does a few things:
1. We have a file MimaExcludes.scala exclusively for excludes.
2. The test runner tells users about that file if a test fails.
3. I've added back the excludes used from 0.9->1.0. We should keep
these in the project as an official audit trail of times where
we decided to make exceptions.
Author: Patrick Wendell <pwendell@gmail.com>
Closes #937 from pwendell/mima and squashes the following commits:
7ee0db2 [Patrick Wendell] Better explanation for how to use MIMA excludes.
Diffstat (limited to 'dev')
-rwxr-xr-x | dev/mima | 34 | ||||
-rwxr-xr-x | dev/run-tests | 3 |
2 files changed, 35 insertions, 2 deletions
diff --git a/dev/mima b/dev/mima new file mode 100755 index 0000000000..d409999025 --- /dev/null +++ b/dev/mima @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +set -o pipefail + +# Go to the Spark project root directory +FWDIR="$(cd `dirname $0`/..; pwd)" +cd $FWDIR + +./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore +echo -e "q\n" | sbt/sbt mima-report-binary-issues | grep -v -e "info.*Resolving" +ret_val=$? + +if [ $ret_val != 0 ]; then + echo "NOTE: Exceptions to binary compatibility can be added in project/MimaExcludes.scala" +fi + +exit $ret_val diff --git a/dev/run-tests b/dev/run-tests index 6043f859ae..93d6692f83 100755 --- a/dev/run-tests +++ b/dev/run-tests @@ -81,5 +81,4 @@ fi echo "=========================================================================" echo "Detecting binary incompatibilites with MiMa" echo "=========================================================================" -./bin/spark-class org.apache.spark.tools.GenerateMIMAIgnore -echo -e "q\n" | sbt/sbt mima-report-binary-issues | grep -v -e "info.*Resolving" +dev/mima |