diff options
| author | Yin Huai <yhuai@databricks.com> | 2015-07-27 15:49:42 -0700 |
|---|---|---|
| committer | Yin Huai <yhuai@databricks.com> | 2015-07-27 15:49:42 -0700 |
| commit | dafe8d857dff4c61981476282cbfe11f5c008078 (patch) | |
| tree | 1551915a16edaaa0697d710fb426f15446b4b1af /dev | |
| parent | ab625956616664c2b4861781a578311da75a9ae4 (diff) | |
| download | spark-dafe8d857dff4c61981476282cbfe11f5c008078.tar.gz spark-dafe8d857dff4c61981476282cbfe11f5c008078.tar.bz2 spark-dafe8d857dff4c61981476282cbfe11f5c008078.zip | |
[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint.
Instead of disabling all python style check, we should enable PEP8. So, this PR just comments out the part installing pylint.
Author: Yin Huai <yhuai@databricks.com>
Closes #7704 from yhuai/SPARK-9385 and squashes the following commits:
0056359 [Yin Huai] Enable PEP8 but disable installing pylint.
Diffstat (limited to 'dev')
| -rwxr-xr-x | dev/lint-python | 30 | ||||
| -rwxr-xr-x | dev/run-tests.py | 5 |
2 files changed, 17 insertions, 18 deletions
diff --git a/dev/lint-python b/dev/lint-python index 53bccc1fab..575dbb0ae3 100755 --- a/dev/lint-python +++ b/dev/lint-python @@ -58,21 +58,21 @@ export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint" export "PYLINT_HOME=$PYTHONPATH" export "PATH=$PYTHONPATH:$PATH" -if [ ! -d "$PYLINT_HOME" ]; then - mkdir "$PYLINT_HOME" - # Redirect the annoying pylint installation output. - easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO" - easy_install_status="$?" - - if [ "$easy_install_status" -ne 0 ]; then - echo "Unable to install pylint locally in \"$PYTHONPATH\"." - cat "$PYLINT_INSTALL_INFO" - exit "$easy_install_status" - fi - - rm "$PYLINT_INSTALL_INFO" - -fi +# if [ ! -d "$PYLINT_HOME" ]; then +# mkdir "$PYLINT_HOME" +# # Redirect the annoying pylint installation output. +# easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO" +# easy_install_status="$?" +# +# if [ "$easy_install_status" -ne 0 ]; then +# echo "Unable to install pylint locally in \"$PYTHONPATH\"." +# cat "$PYLINT_INSTALL_INFO" +# exit "$easy_install_status" +# fi +# +# rm "$PYLINT_INSTALL_INFO" +# +# fi # There is no need to write this output to a file #+ first, but we do so so that the check status can diff --git a/dev/run-tests.py b/dev/run-tests.py index d1cb66860b..1f0d218514 100755 --- a/dev/run-tests.py +++ b/dev/run-tests.py @@ -198,9 +198,8 @@ def run_scala_style_checks(): def run_python_style_checks(): - # set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE") - # run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")]) - pass + set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE") + run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")]) def build_spark_documentation(): |