diff options
author | DB Tsai <dbtsai@alpinenow.com> | 2014-07-28 11:34:19 -0700 |
---|---|---|
committer | Xiangrui Meng <meng@databricks.com> | 2014-07-28 11:34:19 -0700 |
commit | 255b56f9f530e8594a7e6055ae07690454c66799 (patch) | |
tree | 2a111567e943545679bc2ab1eb3d447e7414b7d8 /docs/sql-programming-guide.md | |
parent | 2b8d89e30ebfe2272229a1eddd7542d7437c9924 (diff) | |
download | spark-255b56f9f530e8594a7e6055ae07690454c66799.tar.gz spark-255b56f9f530e8594a7e6055ae07690454c66799.tar.bz2 spark-255b56f9f530e8594a7e6055ae07690454c66799.zip |
[SPARK-2479][MLlib] Comparing floating-point numbers using relative error in UnitTests
Floating point math is not exact, and most floating-point numbers end up being slightly imprecise due to rounding errors.
Simple values like 0.1 cannot be precisely represented using binary floating point numbers, and the limited precision of floating point numbers means that slight changes in the order of operations or the precision of intermediates can change the result.
That means that comparing two floats to see if they are equal is usually not what we want. As long as this imprecision stays small, it can usually be ignored.
Based on discussion in the community, we have implemented two different APIs for relative tolerance, and absolute tolerance. It makes sense that test writers should know which one they need depending on their circumstances.
Developers also need to explicitly specify the eps, and there is no default value which will sometimes cause confusion.
When comparing against zero using relative tolerance, a exception will be raised to warn users that it's meaningless.
For relative tolerance, users can now write
assert(23.1 ~== 23.52 relTol 0.02)
assert(23.1 ~== 22.74 relTol 0.02)
assert(23.1 ~= 23.52 relTol 0.02)
assert(23.1 ~= 22.74 relTol 0.02)
assert(!(23.1 !~= 23.52 relTol 0.02))
assert(!(23.1 !~= 22.74 relTol 0.02))
// This will throw exception with the following message.
// "Did not expect 23.1 and 23.52 to be within 0.02 using relative tolerance."
assert(23.1 !~== 23.52 relTol 0.02)
// "Expected 23.1 and 22.34 to be within 0.02 using relative tolerance."
assert(23.1 ~== 22.34 relTol 0.02)
For absolute error,
assert(17.8 ~== 17.99 absTol 0.2)
assert(17.8 ~== 17.61 absTol 0.2)
assert(17.8 ~= 17.99 absTol 0.2)
assert(17.8 ~= 17.61 absTol 0.2)
assert(!(17.8 !~= 17.99 absTol 0.2))
assert(!(17.8 !~= 17.61 absTol 0.2))
// This will throw exception with the following message.
// "Did not expect 17.8 and 17.99 to be within 0.2 using absolute error."
assert(17.8 !~== 17.99 absTol 0.2)
// "Expected 17.8 and 17.59 to be within 0.2 using absolute error."
assert(17.8 ~== 17.59 absTol 0.2)
Authors:
DB Tsai <dbtsaialpinenow.com>
Marek Kolodziej <marekalpinenow.com>
Author: DB Tsai <dbtsai@alpinenow.com>
Closes #1425 from dbtsai/SPARK-2479_comparing_floating_point and squashes the following commits:
8c7cbcc [DB Tsai] Alpine Data Labs
Diffstat (limited to 'docs/sql-programming-guide.md')
0 files changed, 0 insertions, 0 deletions