diff options
author | Wenchen Fan <cloud0fan@outlook.com> | 2015-06-12 16:38:28 +0800 |
---|---|---|
committer | Cheng Lian <lian@databricks.com> | 2015-06-12 16:38:28 +0800 |
commit | c19c78577a211eefe1112ebd4670a4ce7c3cc3be (patch) | |
tree | 47f04bc59d8ccffb756424a310f034240e48f2bc /ec2 | |
parent | e428b3a951377d47aa80d5f26d6bab979e72e8ab (diff) | |
download | spark-c19c78577a211eefe1112ebd4670a4ce7c3cc3be.tar.gz spark-c19c78577a211eefe1112ebd4670a4ce7c3cc3be.tar.bz2 spark-c19c78577a211eefe1112ebd4670a4ce7c3cc3be.zip |
[SQL] [MINOR] correct semanticEquals logic
It's a follow up of https://github.com/apache/spark/pull/6173, for expressions like `Coalesce` that have a `Seq[Expression]`, when we do semantic equal check for it, we need to do semantic equal check for all of its children.
Also we can just use `Seq[(Expression, NamedExpression)]` instead of `Map[Expression, NamedExpression]` as we only search it with `find`.
chenghao-intel, I agree that we probably never knows `semanticEquals` in a general way, but I think we have done that in `TreeNode`, so we can use similar logic. Then we can handle something like `Coalesce(children: Seq[Expression])` correctly.
Author: Wenchen Fan <cloud0fan@outlook.com>
Closes #6261 from cloud-fan/tmp and squashes the following commits:
4daef88 [Wenchen Fan] address comments
dd8fbd9 [Wenchen Fan] correct semanticEquals
Diffstat (limited to 'ec2')
0 files changed, 0 insertions, 0 deletions