aboutsummaryrefslogtreecommitdiff
path: root/examples
diff options
context:
space:
mode:
authorSean Owen <sowen@cloudera.com>2014-01-07 09:38:45 +0000
committerSean Owen <sowen@cloudera.com>2014-01-07 09:38:45 +0000
commit4b92a20232bc24fd858ed4eb7c45462241e36829 (patch)
tree2225af15ac3f24f52ec2204bc9e8a65233c9d9b0 /examples
parent7379b2915f5b75476932e2098b83050f7726829e (diff)
downloadspark-4b92a20232bc24fd858ed4eb7c45462241e36829.tar.gz
spark-4b92a20232bc24fd858ed4eb7c45462241e36829.tar.bz2
spark-4b92a20232bc24fd858ed4eb7c45462241e36829.zip
Issue #318 : minor style updates per review from Reynold Xin
Diffstat (limited to 'examples')
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaHdfsLR.java5
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaKMeans.java3
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java3
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaPageRank.java4
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java3
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaTC.java3
-rw-r--r--examples/src/main/java/org/apache/spark/examples/JavaWordCount.java3
-rw-r--r--examples/src/main/java/org/apache/spark/mllib/examples/JavaALS.java5
-rw-r--r--examples/src/main/java/org/apache/spark/mllib/examples/JavaKMeans.java3
-rw-r--r--examples/src/main/java/org/apache/spark/mllib/examples/JavaLR.java3
10 files changed, 2 insertions, 33 deletions
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaHdfsLR.java b/examples/src/main/java/org/apache/spark/examples/JavaHdfsLR.java
index 71bd3b4821..d552c47b22 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaHdfsLR.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaHdfsLR.java
@@ -35,9 +35,6 @@ public final class JavaHdfsLR {
private static final int D = 10; // Number of dimensions
private static final Random rand = new Random(42);
- private JavaHdfsLR() {
- }
-
static class DataPoint implements Serializable {
DataPoint(double[] x, double y) {
this.x = x;
@@ -57,7 +54,7 @@ public final class JavaHdfsLR {
double y = Double.parseDouble(tok[0]);
double[] x = new double[D];
for (int i = 0; i < D; i++) {
- x[i] = Double.parseDouble(tok[i+1]);
+ x[i] = Double.parseDouble(tok[i + 1]);
}
return new DataPoint(x, y);
}
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaKMeans.java b/examples/src/main/java/org/apache/spark/examples/JavaKMeans.java
index 0808f33e6a..0dc879275a 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaKMeans.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaKMeans.java
@@ -36,9 +36,6 @@ public final class JavaKMeans {
private static final Pattern SPACE = Pattern.compile(" ");
- private JavaKMeans() {
- }
-
/** Parses numbers split by whitespace to a vector */
static Vector parseVector(String line) {
String[] splits = SPACE.split(line);
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java b/examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java
index d45d96d804..9eb1cadd71 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaLogQuery.java
@@ -54,9 +54,6 @@ public final class JavaLogQuery {
public static final Pattern apacheLogRegex = Pattern.compile(
"^([\\d.]+) (\\S+) (\\S+) \\[([\\w\\d:/]+\\s[+\\-]\\d{4})\\] \"(.+?)\" (\\d{3}) ([\\d\\-]+) \"([^\"]+)\" \"([^\"]+)\".*");
- private JavaLogQuery() {
- }
-
/** Tracks the total query count and number of aggregate bytes for a particular group. */
public static class Stats implements Serializable {
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaPageRank.java b/examples/src/main/java/org/apache/spark/examples/JavaPageRank.java
index 12d2cce1a7..a84245b0c7 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaPageRank.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaPageRank.java
@@ -17,7 +17,6 @@
package org.apache.spark.examples;
-import org.apache.spark.SparkContext;
import scala.Tuple2;
import org.apache.spark.api.java.JavaPairRDD;
import org.apache.spark.api.java.JavaRDD;
@@ -43,9 +42,6 @@ import java.util.regex.Pattern;
public final class JavaPageRank {
private static final Pattern SPACES = Pattern.compile("\\s+");
- private JavaPageRank() {
- }
-
private static class Sum extends Function2<Double, Double, Double> {
@Override
public Double call(Double a, Double b) {
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java b/examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java
index f6ed510e05..3ec4a58d48 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java
@@ -28,9 +28,6 @@ import java.util.List;
/** Computes an approximation to pi */
public final class JavaSparkPi {
- private JavaSparkPi() {
- }
-
public static void main(String[] args) throws Exception {
if (args.length == 0) {
System.err.println("Usage: JavaLogQuery <master> [slices]");
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaTC.java b/examples/src/main/java/org/apache/spark/examples/JavaTC.java
index 12b564d1ef..2ceb0fd94b 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaTC.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaTC.java
@@ -37,9 +37,6 @@ public final class JavaTC {
private static final int numVertices = 100;
private static final Random rand = new Random(42);
- private JavaTC() {
- }
-
static List<Tuple2<Integer, Integer>> generateGraph() {
Set<Tuple2<Integer, Integer>> edges = new HashSet<Tuple2<Integer, Integer>>(numEdges);
while (edges.size() < numEdges) {
diff --git a/examples/src/main/java/org/apache/spark/examples/JavaWordCount.java b/examples/src/main/java/org/apache/spark/examples/JavaWordCount.java
index fc9beb8fe5..6651f98d56 100644
--- a/examples/src/main/java/org/apache/spark/examples/JavaWordCount.java
+++ b/examples/src/main/java/org/apache/spark/examples/JavaWordCount.java
@@ -32,9 +32,6 @@ import java.util.regex.Pattern;
public final class JavaWordCount {
private static final Pattern SPACE = Pattern.compile(" ");
- private JavaWordCount() {
- }
-
public static void main(String[] args) throws Exception {
if (args.length < 2) {
System.err.println("Usage: JavaWordCount <master> <file>");
diff --git a/examples/src/main/java/org/apache/spark/mllib/examples/JavaALS.java b/examples/src/main/java/org/apache/spark/mllib/examples/JavaALS.java
index c42d9cb788..435a86e62a 100644
--- a/examples/src/main/java/org/apache/spark/mllib/examples/JavaALS.java
+++ b/examples/src/main/java/org/apache/spark/mllib/examples/JavaALS.java
@@ -33,10 +33,7 @@ import scala.Tuple2;
/**
* Example using MLLib ALS from Java.
*/
-public final class JavaALS {
-
- private JavaALS() {
- }
+public final class JavaALS {
static class ParseRating extends Function<String, Rating> {
private static final Pattern COMMA = Pattern.compile(",");
diff --git a/examples/src/main/java/org/apache/spark/mllib/examples/JavaKMeans.java b/examples/src/main/java/org/apache/spark/mllib/examples/JavaKMeans.java
index 9d10473aed..4b2658f257 100644
--- a/examples/src/main/java/org/apache/spark/mllib/examples/JavaKMeans.java
+++ b/examples/src/main/java/org/apache/spark/mllib/examples/JavaKMeans.java
@@ -32,9 +32,6 @@ import java.util.regex.Pattern;
*/
public final class JavaKMeans {
- private JavaKMeans() {
- }
-
static class ParsePoint extends Function<String, double[]> {
private static final Pattern SPACE = Pattern.compile(" ");
diff --git a/examples/src/main/java/org/apache/spark/mllib/examples/JavaLR.java b/examples/src/main/java/org/apache/spark/mllib/examples/JavaLR.java
index b057f71e08..21586ce817 100644
--- a/examples/src/main/java/org/apache/spark/mllib/examples/JavaLR.java
+++ b/examples/src/main/java/org/apache/spark/mllib/examples/JavaLR.java
@@ -34,9 +34,6 @@ import java.util.regex.Pattern;
*/
public final class JavaLR {
- private JavaLR() {
- }
-
static class ParsePoint extends Function<String, LabeledPoint> {
private static final Pattern COMMA = Pattern.compile(",");
private static final Pattern SPACE = Pattern.compile(" ");