aboutsummaryrefslogtreecommitdiff
path: root/extras
diff options
context:
space:
mode:
authorYin Huai <huai@cse.ohio-state.edu>2014-08-02 13:16:41 -0700
committerMichael Armbrust <michael@databricks.com>2014-08-02 13:16:53 -0700
commit91de0dc1654d609dc1ff8fa9a07ba18043ad61c6 (patch)
tree9cb43882eba9311c918b87d7def3abd93999fe95 /extras
parent8d6ac2b95ab48d9fffe82ef04cef3b22c2c139e0 (diff)
downloadspark-91de0dc1654d609dc1ff8fa9a07ba18043ad61c6.tar.gz
spark-91de0dc1654d609dc1ff8fa9a07ba18043ad61c6.tar.bz2
spark-91de0dc1654d609dc1ff8fa9a07ba18043ad61c6.zip
[SQL] Set outputPartitioning of BroadcastHashJoin correctly.
I think we will not generate the plan triggering this bug at this moment. But, let me explain it... Right now, we are using `left.outputPartitioning` as the `outputPartitioning` of a `BroadcastHashJoin`. We may have a wrong physical plan for cases like... ```sql SELECT l.key, count(*) FROM (SELECT key, count(*) as cnt FROM src GROUP BY key) l // This is buildPlan JOIN r // This is the streamedPlan ON (l.cnt = r.value) GROUP BY l.key ``` Let's say we have a `BroadcastHashJoin` on `l` and `r`. For this case, we will pick `l`'s `outputPartitioning` for the `outputPartitioning`of the `BroadcastHashJoin` on `l` and `r`. Also, because the last `GROUP BY` is using `l.key` as the key, we will not introduce an `Exchange` for this aggregation. However, `r`'s outputPartitioning may not match the required distribution of the last `GROUP BY` and we fail to group data correctly. JIRA is being reindexed. I will create a JIRA ticket once it is back online. Author: Yin Huai <huai@cse.ohio-state.edu> Closes #1735 from yhuai/BroadcastHashJoin and squashes the following commits: 96d9cb3 [Yin Huai] Set outputPartitioning correctly. (cherry picked from commit 67bd8e3c217a80c3117a6e3853aa60fe13d08c91) Signed-off-by: Michael Armbrust <michael@databricks.com>
Diffstat (limited to 'extras')
0 files changed, 0 insertions, 0 deletions