diff options
author | Dongjoon Hyun <dongjoon@apache.org> | 2016-04-24 20:40:03 -0700 |
---|---|---|
committer | Reynold Xin <rxin@databricks.com> | 2016-04-24 20:40:03 -0700 |
commit | d34d6503786bbe429c10ddb1879519cc9bd709b6 (patch) | |
tree | 885752ae5137e5a2f87dd8802c2e789ea271ee77 /mllib/src/test/java/org | |
parent | d0ca5797a8fc55a3046cdfad8860ba3a29f72b51 (diff) | |
download | spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.tar.gz spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.tar.bz2 spark-d34d6503786bbe429c10ddb1879519cc9bd709b6.zip |
[SPARK-14868][BUILD] Enable NewLineAtEofChecker in checkstyle and fix lint-java errors
## What changes were proposed in this pull request?
Spark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most Java code also comply with the rule. This PR aims to enforce the same rule `NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java errors since SPARK-14465. The followings are the items.
- Adds a new line at the end of the files (19 files)
- Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2 LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder)
## How was this patch tested?
After the Jenkins test succeeds, `dev/lint-java` should pass. (Currently, Jenkins dose not run lint-java.)
```bash
$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.
```
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes #12632 from dongjoon-hyun/SPARK-14868.
Diffstat (limited to 'mllib/src/test/java/org')
2 files changed, 6 insertions, 6 deletions
diff --git a/mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java b/mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java index 5aec52ac72..4f40fd65b9 100644 --- a/mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java +++ b/mllib/src/test/java/org/apache/spark/ml/classification/JavaRandomForestClassifierSuite.java @@ -81,15 +81,15 @@ public class JavaRandomForestClassifierSuite implements Serializable { for (String featureSubsetStrategy: RandomForestClassifier.supportedFeatureSubsetStrategies()) { rf.setFeatureSubsetStrategy(featureSubsetStrategy); } - String realStrategies[] = {".1", ".10", "0.10", "0.1", "0.9", "1.0"}; + String[] realStrategies = {".1", ".10", "0.10", "0.1", "0.9", "1.0"}; for (String strategy: realStrategies) { rf.setFeatureSubsetStrategy(strategy); } - String integerStrategies[] = {"1", "10", "100", "1000", "10000"}; + String[] integerStrategies = {"1", "10", "100", "1000", "10000"}; for (String strategy: integerStrategies) { rf.setFeatureSubsetStrategy(strategy); } - String invalidStrategies[] = {"-.1", "-.10", "-0.10", ".0", "0.0", "1.1", "0"}; + String[] invalidStrategies = {"-.1", "-.10", "-0.10", ".0", "0.0", "1.1", "0"}; for (String strategy: invalidStrategies) { try { rf.setFeatureSubsetStrategy(strategy); diff --git a/mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java b/mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java index a8736669f7..38b895f1fd 100644 --- a/mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java +++ b/mllib/src/test/java/org/apache/spark/ml/regression/JavaRandomForestRegressorSuite.java @@ -81,15 +81,15 @@ public class JavaRandomForestRegressorSuite implements Serializable { for (String featureSubsetStrategy: RandomForestRegressor.supportedFeatureSubsetStrategies()) { rf.setFeatureSubsetStrategy(featureSubsetStrategy); } - String realStrategies[] = {".1", ".10", "0.10", "0.1", "0.9", "1.0"}; + String[] realStrategies = {".1", ".10", "0.10", "0.1", "0.9", "1.0"}; for (String strategy: realStrategies) { rf.setFeatureSubsetStrategy(strategy); } - String integerStrategies[] = {"1", "10", "100", "1000", "10000"}; + String[] integerStrategies = {"1", "10", "100", "1000", "10000"}; for (String strategy: integerStrategies) { rf.setFeatureSubsetStrategy(strategy); } - String invalidStrategies[] = {"-.1", "-.10", "-0.10", ".0", "0.0", "1.1", "0"}; + String[] invalidStrategies = {"-.1", "-.10", "-0.10", ".0", "0.0", "1.1", "0"}; for (String strategy: invalidStrategies) { try { rf.setFeatureSubsetStrategy(strategy); |