diff options
author | Yong Tang <yong.tang.github@outlook.com> | 2016-04-14 17:23:16 -0700 |
---|---|---|
committer | Xiangrui Meng <meng@databricks.com> | 2016-04-14 17:23:16 -0700 |
commit | 01dd1f5c07f5c9ba91389c1556f911b028475cd3 (patch) | |
tree | 62e3e960564366c5226e49d0a7e29cd2d8c58735 /mllib/src/test | |
parent | d7e124edfe2578ecdf8e816a4dda3ce430a09172 (diff) | |
download | spark-01dd1f5c07f5c9ba91389c1556f911b028475cd3.tar.gz spark-01dd1f5c07f5c9ba91389c1556f911b028475cd3.tar.bz2 spark-01dd1f5c07f5c9ba91389c1556f911b028475cd3.zip |
[SPARK-14565][ML] RandomForest should use parseInt and parseDouble for feature subset size instead of regexes
## What changes were proposed in this pull request?
This fix tries to change RandomForest's supported strategies from using regexes to using parseInt and
parseDouble, for the purpose of robustness and maintainability.
## How was this patch tested?
Existing tests passed.
Author: Yong Tang <yong.tang.github@outlook.com>
Closes #12360 from yongtang/SPARK-14565.
Diffstat (limited to 'mllib/src/test')
-rw-r--r-- | mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala index 6db9ce150d..1719f9fab5 100644 --- a/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala +++ b/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala @@ -440,7 +440,7 @@ class RandomForestSuite extends SparkFunSuite with MLlibTestSparkContext { val invalidStrategies = Array("-.1", "-.10", "-0.10", ".0", "0.0", "1.1", "0") for (invalidStrategy <- invalidStrategies) { - intercept[MatchError]{ + intercept[IllegalArgumentException]{ val metadata = DecisionTreeMetadata.buildMetadata(rdd, strategy, numTrees = 1, invalidStrategy) } @@ -463,7 +463,7 @@ class RandomForestSuite extends SparkFunSuite with MLlibTestSparkContext { checkFeatureSubsetStrategy(numTrees = 2, strategy, expected) } for (invalidStrategy <- invalidStrategies) { - intercept[MatchError]{ + intercept[IllegalArgumentException]{ val metadata = DecisionTreeMetadata.buildMetadata(rdd, strategy, numTrees = 2, invalidStrategy) } |