diff options
| author | Holden Karau <holden@pigscanfly.ca> | 2015-10-07 12:00:56 -0700 |
|---|---|---|
| committer | Joseph K. Bradley <joseph@databricks.com> | 2015-10-07 12:00:56 -0700 |
| commit | 5be5d247440d6346d667c4b3d817666126f62906 (patch) | |
| tree | 7a2be64c9c4187f520637b61b9c156f3a664bf9b /mllib | |
| parent | 6ca27f855075d65eb4535f1f2ed4fc9e68744231 (diff) | |
| download | spark-5be5d247440d6346d667c4b3d817666126f62906.tar.gz spark-5be5d247440d6346d667c4b3d817666126f62906.tar.bz2 spark-5be5d247440d6346d667c4b3d817666126f62906.zip | |
[SPARK-9841] [ML] Make clear public
It is currently impossible to clear Param values once set. It would be helpful to be able to.
Author: Holden Karau <holden@pigscanfly.ca>
Closes #8619 from holdenk/SPARK-9841-params-clear-needs-to-be-public.
Diffstat (limited to 'mllib')
| -rw-r--r-- | mllib/src/main/scala/org/apache/spark/ml/param/params.scala | 2 | ||||
| -rw-r--r-- | mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/mllib/src/main/scala/org/apache/spark/ml/param/params.scala b/mllib/src/main/scala/org/apache/spark/ml/param/params.scala index 48f6269e57..ec98b05e13 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/param/params.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/param/params.scala @@ -454,7 +454,7 @@ trait Params extends Identifiable with Serializable { /** * Clears the user-supplied value for the input param. */ - protected final def clear(param: Param[_]): this.type = { + final def clear(param: Param[_]): this.type = { shouldOwn(param) paramMap.remove(param) this diff --git a/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala index dfab82c8b6..a2ea279f5d 100644 --- a/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala +++ b/mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala @@ -156,6 +156,11 @@ class ParamsSuite extends SparkFunSuite { solver.clearMaxIter() assert(!solver.isSet(maxIter)) + // Re-set and clear maxIter using the generic clear API + solver.setMaxIter(10) + solver.clear(maxIter) + assert(!solver.isSet(maxIter)) + val copied = solver.copy(ParamMap(solver.maxIter -> 50)) assert(copied.uid === solver.uid) assert(copied.getInputCol === solver.getInputCol) |