diff options
| author | Jacek Laskowski <jacek@japila.pl> | 2016-01-07 21:12:57 +0000 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-01-07 21:12:57 +0000 |
| commit | 1b2c2162af4d5d2d950af94571e69273b49bf913 (patch) | |
| tree | 38e73ce8a25605b4432b3cf2bd8e4b69a6e9897a /network | |
| parent | 07b314a57a638a232ee0b5cd14169e57d742f0f9 (diff) | |
| download | spark-1b2c2162af4d5d2d950af94571e69273b49bf913.tar.gz spark-1b2c2162af4d5d2d950af94571e69273b49bf913.tar.bz2 spark-1b2c2162af4d5d2d950af94571e69273b49bf913.zip | |
[STREAMING][MINOR] More contextual information in logs + minor code i…
…mprovements
Please review and merge at your convenience. Thanks!
Author: Jacek Laskowski <jacek@japila.pl>
Closes #10595 from jaceklaskowski/streaming-minor-fixes.
Diffstat (limited to 'network')
3 files changed, 4 insertions, 4 deletions
diff --git a/network/common/src/main/java/org/apache/spark/network/client/StreamCallback.java b/network/common/src/main/java/org/apache/spark/network/client/StreamCallback.java index 51d34cac6e..29e6a30dc1 100644 --- a/network/common/src/main/java/org/apache/spark/network/client/StreamCallback.java +++ b/network/common/src/main/java/org/apache/spark/network/client/StreamCallback.java @@ -21,8 +21,8 @@ import java.io.IOException; import java.nio.ByteBuffer; /** - * Callback for streaming data. Stream data will be offered to the {@link onData(String, ByteBuffer)} - * method as it arrives. Once all the stream data is received, {@link onComplete(String)} will be + * Callback for streaming data. Stream data will be offered to the {@link #onData(String, ByteBuffer)} + * method as it arrives. Once all the stream data is received, {@link #onComplete(String)} will be * called. * <p> * The network library guarantees that a single thread will call these methods at a time, but diff --git a/network/common/src/main/java/org/apache/spark/network/client/TransportClient.java b/network/common/src/main/java/org/apache/spark/network/client/TransportClient.java index c49ca4d5ee..e15f096d36 100644 --- a/network/common/src/main/java/org/apache/spark/network/client/TransportClient.java +++ b/network/common/src/main/java/org/apache/spark/network/client/TransportClient.java @@ -288,7 +288,7 @@ public class TransportClient implements Closeable { /** * Removes any state associated with the given RPC. * - * @param requestId The RPC id returned by {@link #sendRpc(byte[], RpcResponseCallback)}. + * @param requestId The RPC id returned by {@link #sendRpc(ByteBuffer, RpcResponseCallback)}. */ public void removeRpcRequest(long requestId) { handler.removeRpcRequest(requestId); diff --git a/network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java b/network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java index c6ed0f459a..a99c3015b0 100644 --- a/network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java +++ b/network/common/src/main/java/org/apache/spark/network/server/RpcHandler.java @@ -57,7 +57,7 @@ public abstract class RpcHandler { /** * Receives an RPC message that does not expect a reply. The default implementation will - * call "{@link receive(TransportClient, byte[], RpcResponseCallback)}" and log a warning if + * call "{@link #receive(TransportClient, ByteBuffer, RpcResponseCallback)}" and log a warning if * any of the callback methods are called. * * @param client A channel client which enables the handler to make requests back to the sender |