diff options
author | Josh Rosen <joshrosen@apache.org> | 2014-09-02 10:45:14 -0700 |
---|---|---|
committer | Andrew Or <andrewor14@gmail.com> | 2014-09-09 15:26:22 -0700 |
commit | 23fd3e8b95845b956b3c90df660bc3cf0ed42d28 (patch) | |
tree | 75e24fa6f089cb7134be2c587f948455cfa86837 /pom.xml | |
parent | e5f77ae97bf78a2b57ef2e0e2ff8c9ed4bb8c50d (diff) | |
download | spark-23fd3e8b95845b956b3c90df660bc3cf0ed42d28.tar.gz spark-23fd3e8b95845b956b3c90df660bc3cf0ed42d28.tar.bz2 spark-23fd3e8b95845b956b3c90df660bc3cf0ed42d28.zip |
[SPARK-3061] Fix Maven build under Windows
The Maven build was failing on Windows because it tried to call the unix `unzip` utility to extract the Py4J files into core's build directory. I've fixed this issue by using the `maven-antrun-plugin` to perform the unzipping.
I also fixed an issue that prevented tests from running under Windows:
In the Maven ScalaTest plugin, the filename listed in <filereports> is placed under the <reportsDirectory>; the current code places it in a subdirectory of reportsDirectory, e.g.
```
${project.build.directory}/surefire-reports/${project.build.directory}/SparkTestSuite.txt
```
This caused problems under Windows because it would try to create a subdirectory named "c:\\".
Note that the tests still fail under Windows (for other reasons); this PR just allows them to run and fail rather than crash when trying to create the test reports directory.
Author: Josh Rosen <joshrosen@apache.org>
Author: Josh Rosen <rosenville@gmail.com>
Author: Josh Rosen <joshrosen@databricks.com>
Closes #2165 from JoshRosen/windows-support and squashes the following commits:
651d210 [Josh Rosen] Unzip to python/build instead of core/build
fbf3e61 [Josh Rosen] 4 spaces -> 2 spaces
e347668 [Josh Rosen] Fix Maven scalatest filereports path:
4994af1 [Josh Rosen] [SPARK-3061] Use maven-antrun-plugin to unzip Py4J.
Diffstat (limited to 'pom.xml')
-rw-r--r-- | pom.xml | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -878,7 +878,7 @@ <configuration> <reportsDirectory>${project.build.directory}/surefire-reports</reportsDirectory> <junitxml>.</junitxml> - <filereports>${project.build.directory}/SparkTestSuite.txt</filereports> + <filereports>SparkTestSuite.txt</filereports> <argLine>-Xmx3g -XX:MaxPermSize=${MaxPermGen} -XX:ReservedCodeCacheSize=512m</argLine> <stderr /> <systemProperties> |