diff options
author | Aaron Davidson <aaron@databricks.com> | 2014-05-12 11:08:52 -0700 |
---|---|---|
committer | Patrick Wendell <pwendell@gmail.com> | 2014-05-12 11:08:52 -0700 |
commit | 3af1f386439cdddd42e545ad63d089f4dfdf9f8a (patch) | |
tree | c644538e90be5141e7238afdf08caa54563634db /pom.xml | |
parent | af15c82bfe2c3f73142b8f310784a0e85841539d (diff) | |
download | spark-3af1f386439cdddd42e545ad63d089f4dfdf9f8a.tar.gz spark-3af1f386439cdddd42e545ad63d089f4dfdf9f8a.tar.bz2 spark-3af1f386439cdddd42e545ad63d089f4dfdf9f8a.zip |
SPARK-1772 Stop catching Throwable, let Executors die
The main issue this patch fixes is [SPARK-1772](https://issues.apache.org/jira/browse/SPARK-1772), in which Executors may not die when fatal exceptions (e.g., OOM) are thrown. This patch causes Executors to delegate to the ExecutorUncaughtExceptionHandler when a fatal exception is thrown.
This patch also continues the fight in the neverending war against `case t: Throwable =>`, by only catching Exceptions in many places, and adding a wrapper for Threads and Runnables to make sure any uncaught exceptions are at least printed to the logs.
It also turns out that it is unlikely that the IndestructibleActorSystem actually works, given testing ([here](https://gist.github.com/aarondav/ca1f0cdcd50727f89c0d)). The uncaughtExceptionHandler is not called from the places that we expected it would be.
[SPARK-1620](https://issues.apache.org/jira/browse/SPARK-1620) deals with part of this issue, but refactoring our Actor Systems to ensure that exceptions are dealt with properly is a much bigger change, outside the scope of this PR.
Author: Aaron Davidson <aaron@databricks.com>
Closes #715 from aarondav/throwable and squashes the following commits:
f9b9bfe [Aaron Davidson] Remove other redundant 'throw e'
e937a0a [Aaron Davidson] Address Prashant and Matei's comments
1867867 [Aaron Davidson] [RFC] SPARK-1772 Stop catching Throwable, let Executors die
Diffstat (limited to 'pom.xml')
0 files changed, 0 insertions, 0 deletions