diff options
| author | Prashant Sharma <prashant.s@imaginea.com> | 2014-05-30 01:13:51 -0700 |
|---|---|---|
| committer | Patrick Wendell <pwendell@gmail.com> | 2014-05-30 01:13:51 -0700 |
| commit | 79fa8fd4b198904ca9ed78a821fd924bd1a82902 (patch) | |
| tree | 0390533c6de2a6d6d95660fecbae6bacb618a858 /project/MimaBuild.scala | |
| parent | c8bf4131bc2a2e147e977159fc90e94b85738830 (diff) | |
| download | spark-79fa8fd4b198904ca9ed78a821fd924bd1a82902.tar.gz spark-79fa8fd4b198904ca9ed78a821fd924bd1a82902.tar.bz2 spark-79fa8fd4b198904ca9ed78a821fd924bd1a82902.zip | |
[SPARK-1971] Update MIMA to compare against Spark 1.0.0
Author: Prashant Sharma <prashant.s@imaginea.com>
Closes #910 from ScrapCodes/enable-mima/spark-core and squashes the following commits:
79f3687 [Prashant Sharma] updated Mima to check against version 1.0
1e8969c [Prashant Sharma] Spark core missed out on Mima settings. So in effect we never tested spark core for mima related errors.
Diffstat (limited to 'project/MimaBuild.scala')
| -rw-r--r-- | project/MimaBuild.scala | 32 |
1 files changed, 3 insertions, 29 deletions
diff --git a/project/MimaBuild.scala b/project/MimaBuild.scala index e147be7dda..182ca7615d 100644 --- a/project/MimaBuild.scala +++ b/project/MimaBuild.scala @@ -31,7 +31,7 @@ object MimaBuild { // Read package-private excludes from file val excludeFilePath = (base.getAbsolutePath + "/.mima-excludes") val excludeFile = file(excludeFilePath) - val packagePrivateList: Seq[String] = + val ignoredClasses: Seq[String] = if (!excludeFile.exists()) { Seq() } else { @@ -60,35 +60,9 @@ object MimaBuild { excludePackage("org.apache.spark." + packageName) } - val packagePrivateExcludes = packagePrivateList.flatMap(excludeClass) + val externalExcludeFileClasses = ignoredClasses.flatMap(excludeClass) - /* Excludes specific to a given version of Spark. When comparing the given version against - its immediate predecessor, the excludes listed here will be applied. */ - val versionExcludes = - SparkBuild.SPARK_VERSION match { - case v if v.startsWith("1.0") => - Seq( - excludeSparkPackage("api.java"), - excludeSparkPackage("mllib"), - excludeSparkPackage("streaming") - ) ++ - excludeSparkClass("rdd.ClassTags") ++ - excludeSparkClass("util.XORShiftRandom") ++ - excludeSparkClass("graphx.EdgeRDD") ++ - excludeSparkClass("graphx.VertexRDD") ++ - excludeSparkClass("graphx.impl.GraphImpl") ++ - excludeSparkClass("graphx.impl.RoutingTable") ++ - excludeSparkClass("graphx.util.collection.PrimitiveKeyOpenHashMap") ++ - excludeSparkClass("graphx.util.collection.GraphXPrimitiveKeyOpenHashMap") ++ - excludeSparkClass("mllib.recommendation.MFDataGenerator") ++ - excludeSparkClass("mllib.optimization.SquaredGradient") ++ - excludeSparkClass("mllib.regression.RidgeRegressionWithSGD") ++ - excludeSparkClass("mllib.regression.LassoWithSGD") ++ - excludeSparkClass("mllib.regression.LinearRegressionWithSGD") - case _ => Seq() - } - - defaultExcludes ++ packagePrivateExcludes ++ versionExcludes + defaultExcludes ++ externalExcludeFileClasses } def mimaSettings(sparkHome: File) = mimaDefaultSettings ++ Seq( |