aboutsummaryrefslogtreecommitdiff
path: root/sql/catalyst/src
diff options
context:
space:
mode:
authorCheng Lian <lian@databricks.com>2016-07-25 09:42:39 -0700
committerReynold Xin <rxin@databricks.com>2016-07-25 09:42:39 -0700
commit7ea6d282b925819ddb3874a67b3c9da8cc41f131 (patch)
tree5f343ac3f05a2659593d73ccd9b28575447a6d16 /sql/catalyst/src
parent79826f3c7936ee27457d030c7115d5cac69befd7 (diff)
downloadspark-7ea6d282b925819ddb3874a67b3c9da8cc41f131.tar.gz
spark-7ea6d282b925819ddb3874a67b3c9da8cc41f131.tar.bz2
spark-7ea6d282b925819ddb3874a67b3c9da8cc41f131.zip
[SPARK-16703][SQL] Remove extra whitespace in SQL generation for window functions
## What changes were proposed in this pull request? This PR fixes a minor formatting issue of `WindowSpecDefinition.sql` when no partitioning expressions are present. Before: ```sql ( ORDER BY `a` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) ``` After: ```sql (ORDER BY `a` ASC ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) ``` ## How was this patch tested? New test case added in `ExpressionSQLBuilderSuite`. Author: Cheng Lian <lian@databricks.com> Closes #14334 from liancheng/window-spec-sql-format.
Diffstat (limited to 'sql/catalyst/src')
-rw-r--r--sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala6
1 files changed, 3 insertions, 3 deletions
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
index c0b453dccf..e35192ca2d 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
@@ -82,16 +82,16 @@ case class WindowSpecDefinition(
val partition = if (partitionSpec.isEmpty) {
""
} else {
- "PARTITION BY " + partitionSpec.map(_.sql).mkString(", ")
+ "PARTITION BY " + partitionSpec.map(_.sql).mkString(", ") + " "
}
val order = if (orderSpec.isEmpty) {
""
} else {
- "ORDER BY " + orderSpec.map(_.sql).mkString(", ")
+ "ORDER BY " + orderSpec.map(_.sql).mkString(", ") + " "
}
- s"($partition $order ${frameSpecification.toString})"
+ s"($partition$order${frameSpecification.toString})"
}
}