diff options
| author | Reynold Xin <rxin@databricks.com> | 2015-07-28 09:42:35 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2015-07-28 09:42:35 -0700 |
| commit | 5a2330e546074013ef706ac09028626912ec5475 (patch) | |
| tree | 2bd0fd2ade2e4f0fe8a1ff9354818b0d2facb215 /sql/catalyst | |
| parent | 4af622c855a32b1846242a6dd38b252ca30c8b82 (diff) | |
| download | spark-5a2330e546074013ef706ac09028626912ec5475.tar.gz spark-5a2330e546074013ef706ac09028626912ec5475.tar.bz2 spark-5a2330e546074013ef706ac09028626912ec5475.zip | |
[SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.
Both expressions already implement code generation.
Author: Reynold Xin <rxin@databricks.com>
Closes #7723 from rxin/abs-formatnum and squashes the following commits:
31ed765 [Reynold Xin] [SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.
Diffstat (limited to 'sql/catalyst')
2 files changed, 2 insertions, 3 deletions
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala index b37f530ec6..4ec866475f 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala @@ -68,8 +68,7 @@ case class UnaryPositive(child: Expression) extends UnaryExpression with Expects @ExpressionDescription( usage = "_FUNC_(expr) - Returns the absolute value of the numeric value", extended = "> SELECT _FUNC_('-1');\n1") -case class Abs(child: Expression) - extends UnaryExpression with ExpectsInputTypes with CodegenFallback { +case class Abs(child: Expression) extends UnaryExpression with ExpectsInputTypes { override def inputTypes: Seq[AbstractDataType] = Seq(NumericType) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala index edfffbc01c..6db4e19c24 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala @@ -1139,7 +1139,7 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio * fractional part. */ case class FormatNumber(x: Expression, d: Expression) - extends BinaryExpression with ExpectsInputTypes with CodegenFallback { + extends BinaryExpression with ExpectsInputTypes { override def left: Expression = x override def right: Expression = d |