diff options
| author | Sameer Agarwal <sameer@databricks.com> | 2016-04-18 20:28:22 -0700 |
|---|---|---|
| committer | Reynold Xin <rxin@databricks.com> | 2016-04-18 20:28:22 -0700 |
| commit | 4eae1dbd7c4ec96727f92dd52e3fb9b26b0ec883 (patch) | |
| tree | 1674c2245e7c3fefa3b64ca17d65437d90d832ee /sql/core/src | |
| parent | ed2de0299a5a54b566b91ae9f47b6626c484c1d3 (diff) | |
| download | spark-4eae1dbd7c4ec96727f92dd52e3fb9b26b0ec883.tar.gz spark-4eae1dbd7c4ec96727f92dd52e3fb9b26b0ec883.tar.bz2 spark-4eae1dbd7c4ec96727f92dd52e3fb9b26b0ec883.zip | |
[SPARK-14718][SQL] Avoid mutating ExprCode in doGenCode
## What changes were proposed in this pull request?
The `doGenCode` method currently takes in an `ExprCode`, mutates it and returns the java code to evaluate the given expression. It should instead just return a new `ExprCode` to avoid passing around mutable objects during code generation.
## How was this patch tested?
Existing Tests
Author: Sameer Agarwal <sameer@databricks.com>
Closes #12483 from sameeragarwal/new-exprcode-2.
Diffstat (limited to 'sql/core/src')
| -rw-r--r-- | sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala index 03defc121c..b3e8b37a2e 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala @@ -54,7 +54,7 @@ case class ScalarSubquery( override def eval(input: InternalRow): Any = result - override def doGenCode(ctx: CodegenContext, ev: ExprCode): String = { + override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { Literal.create(result, dataType).doGenCode(ctx, ev) } } |