diff options
author | Huaxin Gao <huaxing@oc0558782468.ibm.com> | 2015-12-03 08:42:21 +0000 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2015-12-03 08:42:21 +0000 |
commit | 5349851f368a1b5dab8a99c0d51c9638ce7aec56 (patch) | |
tree | 7fe5243b5e288e88b97c1b40cac32572ae71e993 /sql/core | |
parent | ec2b6c26c9b6bd59d29b5d7af2742aca7e6e0b07 (diff) | |
download | spark-5349851f368a1b5dab8a99c0d51c9638ce7aec56.tar.gz spark-5349851f368a1b5dab8a99c0d51c9638ce7aec56.tar.bz2 spark-5349851f368a1b5dab8a99c0d51c9638ce7aec56.zip |
[SPARK-12088][SQL] check connection.isClosed before calling connection…
In Java Spec java.sql.Connection, it has
boolean getAutoCommit() throws SQLException
Throws:
SQLException - if a database access error occurs or this method is called on a closed connection
So if conn.getAutoCommit is called on a closed connection, a SQLException will be thrown. Even though the code catch the SQLException and program can continue, I think we should check conn.isClosed before calling conn.getAutoCommit to avoid the unnecessary SQLException.
Author: Huaxin Gao <huaxing@oc0558782468.ibm.com>
Closes #10095 from huaxingao/spark-12088.
Diffstat (limited to 'sql/core')
-rw-r--r-- | sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala index 392d3ed58e..b9dd7f6b40 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala @@ -498,7 +498,7 @@ private[sql] class JDBCRDD( } try { if (null != conn) { - if (!conn.getAutoCommit && !conn.isClosed) { + if (!conn.isClosed && !conn.getAutoCommit) { try { conn.commit() } catch { |