diff options
| author | gatorsmile <gatorsmile@gmail.com> | 2016-09-02 22:31:01 +0800 |
|---|---|---|
| committer | Wenchen Fan <wenchen@databricks.com> | 2016-09-02 22:31:01 +0800 |
| commit | 247a4faf06c1dd47a6543c56929cd0182a03e106 (patch) | |
| tree | c9a90898083b72494aa4a5fc0ce0de12fc0c4def /sql/core | |
| parent | 7ee24dac8e779f6a9bf45371fdc2be83fb679cb2 (diff) | |
| download | spark-247a4faf06c1dd47a6543c56929cd0182a03e106.tar.gz spark-247a4faf06c1dd47a6543c56929cd0182a03e106.tar.bz2 spark-247a4faf06c1dd47a6543c56929cd0182a03e106.zip | |
[SPARK-16935][SQL] Verification of Function-related ExternalCatalog APIs
### What changes were proposed in this pull request?
Function-related `HiveExternalCatalog` APIs do not have enough verification logics. After the PR, `HiveExternalCatalog` and `InMemoryCatalog` become consistent in the error handling.
For example, below is the exception we got when calling `renameFunction`.
```
15:13:40.369 WARN org.apache.hadoop.hive.metastore.ObjectStore: Failed to get database db1, returning NoSuchObjectException
15:13:40.377 WARN org.apache.hadoop.hive.metastore.ObjectStore: Failed to get database db2, returning NoSuchObjectException
15:13:40.739 ERROR DataNucleus.Datastore.Persist: Update of object "org.apache.hadoop.hive.metastore.model.MFunction205629e9" using statement "UPDATE FUNCS SET FUNC_NAME=? WHERE FUNC_ID=?" failed : org.apache.derby.shared.common.error.DerbySQLIntegrityConstraintViolationException: The statement was aborted because it would have caused a duplicate key value in a unique or primary key constraint or unique index identified by 'UNIQUEFUNCTION' defined on 'FUNCS'.
at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source)
```
### How was this patch tested?
Improved the existing test cases to check whether the messages are right.
Author: gatorsmile <gatorsmile@gmail.com>
Closes #14521 from gatorsmile/functionChecking.
Diffstat (limited to 'sql/core')
0 files changed, 0 insertions, 0 deletions