diff options
author | Dongjoon Hyun <dongjoon@apache.org> | 2016-05-03 12:39:37 +0100 |
---|---|---|
committer | Sean Owen <sowen@cloudera.com> | 2016-05-03 12:39:37 +0100 |
commit | a7444570764b0a08b7e908dc7931744f9dbdf3c6 (patch) | |
tree | 331ae7a878a5660e8a9418e88d083b91598fd3e6 /sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java | |
parent | dfd9723dd3b3ff5d47a7f04a4330bf33ffe353ac (diff) | |
download | spark-a7444570764b0a08b7e908dc7931744f9dbdf3c6.tar.gz spark-a7444570764b0a08b7e908dc7931744f9dbdf3c6.tar.bz2 spark-a7444570764b0a08b7e908dc7931744f9dbdf3c6.zip |
[SPARK-15053][BUILD] Fix Java Lint errors on Hive-Thriftserver module
## What changes were proposed in this pull request?
This issue fixes or hides 181 Java linter errors introduced by SPARK-14987 which copied hive service code from Hive. We had better clean up these errors before releasing Spark 2.0.
- Fix UnusedImports (15 lines), RedundantModifier (14 lines), SeparatorWrap (9 lines), MethodParamPad (6 lines), FileTabCharacter (5 lines), ArrayTypeStyle (3 lines), ModifierOrder (3 lines), RedundantImport (1 line), CommentsIndentation (1 line), UpperEll (1 line), FallThrough (1 line), OneStatementPerLine (1 line), NewlineAtEndOfFile (1 line) errors.
- Ignore `LineLength` errors under `hive/service/*` (118 lines).
- Ignore `MethodName` error in `PasswdAuthenticationProvider.java` (1 line).
- Ignore `NoFinalizer` error in `ThreadWithGarbageCleanup.java` (1 line).
## How was this patch tested?
After passing Jenkins building, run `dev/lint-java` manually.
```bash
$ dev/lint-java
Checkstyle checks passed.
```
Author: Dongjoon Hyun <dongjoon@apache.org>
Closes #12831 from dongjoon-hyun/SPARK-15053.
Diffstat (limited to 'sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java')
-rw-r--r-- | sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java index a0ee2109dc..7452137f07 100644 --- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java +++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/RowBasedSet.java @@ -130,8 +130,8 @@ public class RowBasedSet implements RowSet { } private static class RemovableList<E> extends ArrayList<E> { - public RemovableList() { super(); } - public RemovableList(List<E> rows) { super(rows); } + RemovableList() { super(); } + RemovableList(List<E> rows) { super(rows); } @Override public void removeRange(int fromIndex, int toIndex) { super.removeRange(fromIndex, toIndex); |