aboutsummaryrefslogtreecommitdiff
path: root/sql/hive-thriftserver/src
diff options
context:
space:
mode:
authorYin Huai <yhuai@databricks.com>2015-05-27 20:04:29 -0700
committerYin Huai <yhuai@databricks.com>2015-05-27 20:04:29 -0700
commit3c1f1baaf003d50786d3eee1e288f4bac69096f2 (patch)
tree3e82cfd837db7e982243e767c15e08cd70a6bb02 /sql/hive-thriftserver/src
parenta1e092eae57172909ff2af06d8b461742595734c (diff)
downloadspark-3c1f1baaf003d50786d3eee1e288f4bac69096f2.tar.gz
spark-3c1f1baaf003d50786d3eee1e288f4bac69096f2.tar.bz2
spark-3c1f1baaf003d50786d3eee1e288f4bac69096f2.zip
[SPARK-7907] [SQL] [UI] Rename tab ThriftServer to SQL.
This PR has three changes: 1. Renaming the table of `ThriftServer` to `SQL`; 2. Renaming the title of the tab from `ThriftServer` to `JDBC/ODBC Server`; and 3. Renaming the title of the session page from `ThriftServer` to `JDBC/ODBC Session`. https://issues.apache.org/jira/browse/SPARK-7907 Author: Yin Huai <yhuai@databricks.com> Closes #6448 from yhuai/JDBCServer and squashes the following commits: eadcc3d [Yin Huai] Update test. 9168005 [Yin Huai] Use SQL as the tab name. 221831e [Yin Huai] Rename ThriftServer to JDBCServer.
Diffstat (limited to 'sql/hive-thriftserver/src')
-rw-r--r--sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala4
-rw-r--r--sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala2
-rw-r--r--sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala4
-rw-r--r--sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala4
4 files changed, 8 insertions, 6 deletions
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
index 6a2be4a58e..7c48ff4b35 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
@@ -47,7 +47,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
</h4> ++
generateSessionStatsTable() ++
generateSQLStatsTable()
- UIUtils.headerSparkPage("ThriftServer", content, parent, Some(5000))
+ UIUtils.headerSparkPage("JDBC/ODBC Server", content, parent, Some(5000))
}
/** Generate basic stats of the thrift server program */
@@ -143,7 +143,7 @@ private[ui] class ThriftServerPage(parent: ThriftServerTab) extends WebUIPage(""
val headerRow = Seq("User", "IP", "Session ID", "Start Time", "Finish Time", "Duration",
"Total Execute")
def generateDataRow(session: SessionInfo): Seq[Node] = {
- val sessionLink = "%s/ThriftServer/session?id=%s"
+ val sessionLink = "%s/sql/session?id=%s"
.format(UIUtils.prependBaseUri(parent.basePath), session.sessionId)
<tr>
<td> {session.userName} </td>
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
index 33ba038ecc..d9d66dcd85 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
@@ -55,7 +55,7 @@ private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
Total run {sessionStat._2.totalExecution} SQL
</h4> ++
generateSQLStatsTable(sessionStat._2.sessionId)
- UIUtils.headerSparkPage("ThriftServer", content, parent, Some(5000))
+ UIUtils.headerSparkPage("JDBC/ODBC Session", content, parent, Some(5000))
}
/** Generate basic stats of the streaming program */
diff --git a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala
index 343031f10c..94fd8a6bb6 100644
--- a/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala
+++ b/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerTab.scala
@@ -27,7 +27,9 @@ import org.apache.spark.{SparkContext, Logging, SparkException}
* This assumes the given SparkContext has enabled its SparkUI.
*/
private[thriftserver] class ThriftServerTab(sparkContext: SparkContext)
- extends SparkUITab(getSparkUI(sparkContext), "ThriftServer") with Logging {
+ extends SparkUITab(getSparkUI(sparkContext), "sql") with Logging {
+
+ override val name = "SQL"
val parent = getSparkUI(sparkContext)
val listener = HiveThriftServer2.listener
diff --git a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala
index a286dc5825..e1466e0423 100644
--- a/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala
+++ b/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/UISeleniumSuite.scala
@@ -84,11 +84,11 @@ class UISeleniumSuite
eventually(timeout(10 seconds), interval(50 milliseconds)) {
go to baseURL
- find(cssSelector("""ul li a[href*="ThriftServer"]""")) should not be None
+ find(cssSelector("""ul li a[href*="sql"]""")) should not be None
}
eventually(timeout(10 seconds), interval(50 milliseconds)) {
- go to (baseURL + "/ThriftServer")
+ go to (baseURL + "/sql")
find(id("sessionstat")) should not be None
find(id("sqlstat")) should not be None