diff options
author | Sean Owen <sowen@cloudera.com> | 2014-12-24 13:32:51 -0800 |
---|---|---|
committer | Josh Rosen <joshrosen@databricks.com> | 2014-12-24 13:32:51 -0800 |
commit | 29fabb1b528e60b2f65132a9ab64f2fd95b729ba (patch) | |
tree | 00028a1f4ea48e77ede7e8f9bdfaa0cb324b74e7 /sql/hive | |
parent | 199e59aacd540e17b31f38e0e32a3618870e9055 (diff) | |
download | spark-29fabb1b528e60b2f65132a9ab64f2fd95b729ba.tar.gz spark-29fabb1b528e60b2f65132a9ab64f2fd95b729ba.tar.bz2 spark-29fabb1b528e60b2f65132a9ab64f2fd95b729ba.zip |
SPARK-4297 [BUILD] Build warning fixes omnibus
There are a number of warnings generated in a normal, successful build right now. They're mostly Java unchecked cast warnings, which can be suppressed. But there's a grab bag of other Scala language warnings and so on that can all be easily fixed. The forthcoming PR fixes about 90% of the build warnings I see now.
Author: Sean Owen <sowen@cloudera.com>
Closes #3157 from srowen/SPARK-4297 and squashes the following commits:
8c9e469 [Sean Owen] Suppress unchecked cast warnings, and several other build warning fixes
Diffstat (limited to 'sql/hive')
-rw-r--r-- | sql/hive/src/main/scala/org/apache/spark/sql/hive/parquet/FakeParquetSerDe.scala | 2 | ||||
-rw-r--r-- | sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFListListInt.java | 20 |
2 files changed, 9 insertions, 13 deletions
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/parquet/FakeParquetSerDe.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/parquet/FakeParquetSerDe.scala index abed299cd9..2a16c9d1a2 100644 --- a/sql/hive/src/main/scala/org/apache/spark/sql/hive/parquet/FakeParquetSerDe.scala +++ b/sql/hive/src/main/scala/org/apache/spark/sql/hive/parquet/FakeParquetSerDe.scala @@ -32,7 +32,7 @@ import org.apache.hadoop.io.Writable * when "spark.sql.hive.convertMetastoreParquet" is set to true. */ @deprecated("No code should depend on FakeParquetHiveSerDe as it is only intended as a " + - "placeholder in the Hive MetaStore") + "placeholder in the Hive MetaStore", "1.2.0") class FakeParquetSerDe extends SerDe { override def getObjectInspector: ObjectInspector = new ObjectInspector { override def getCategory: Category = Category.PRIMITIVE diff --git a/sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFListListInt.java b/sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFListListInt.java index d2d39a8c4d..808e2986d3 100644 --- a/sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFListListInt.java +++ b/sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDFListListInt.java @@ -23,25 +23,21 @@ import java.util.List; public class UDFListListInt extends UDF { /** - * * @param obj - * SQL schema: array<struct<x: int, y: int, z: int>> - * Java Type: List<List<Integer>> - * @return + * SQL schema: array<struct<x: int, y: int, z: int>> + * Java Type: List<List<Integer>> */ + @SuppressWarnings("unchecked") public long evaluate(Object obj) { if (obj == null) { - return 0l; + return 0L; } - List<List> listList = (List<List>) obj; + List<List<?>> listList = (List<List<?>>) obj; long retVal = 0; - for (List aList : listList) { - @SuppressWarnings("unchecked") - List<Object> list = (List<Object>) aList; - @SuppressWarnings("unchecked") - Integer someInt = (Integer) list.get(1); + for (List<?> aList : listList) { + Number someInt = (Number) aList.get(1); try { - retVal += (long) (someInt.intValue()); + retVal += someInt.longValue(); } catch (NullPointerException e) { System.out.println(e); } |