diff options
author | Patrick Wendell <pwendell@gmail.com> | 2014-03-31 16:25:43 -0700 |
---|---|---|
committer | Patrick Wendell <pwendell@gmail.com> | 2014-03-31 16:25:43 -0700 |
commit | 33b3c2a8c6c71b89744834017a183ea855e1697c (patch) | |
tree | 3833cf85863e15fbc951f7438db180a88aa11632 /streaming/src/test | |
parent | 5731af5be65ccac831445f351baf040a0d007687 (diff) | |
download | spark-33b3c2a8c6c71b89744834017a183ea855e1697c.tar.gz spark-33b3c2a8c6c71b89744834017a183ea855e1697c.tar.bz2 spark-33b3c2a8c6c71b89744834017a183ea855e1697c.zip |
SPARK-1365 [HOTFIX] Fix RateLimitedOutputStream test
This test needs to be fixed. It currently depends on Thread.sleep() having exact-timing
semantics, which is not a valid assumption.
Author: Patrick Wendell <pwendell@gmail.com>
Closes #277 from pwendell/rate-limited-stream and squashes the following commits:
6c0ff81 [Patrick Wendell] SPARK-1365: Fix RateLimitedOutputStream test
Diffstat (limited to 'streaming/src/test')
-rw-r--r-- | streaming/src/test/scala/org/apache/spark/streaming/util/RateLimitedOutputStreamSuite.scala | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/streaming/src/test/scala/org/apache/spark/streaming/util/RateLimitedOutputStreamSuite.scala b/streaming/src/test/scala/org/apache/spark/streaming/util/RateLimitedOutputStreamSuite.scala index 7d18a0fcf7..9ebf7b484f 100644 --- a/streaming/src/test/scala/org/apache/spark/streaming/util/RateLimitedOutputStreamSuite.scala +++ b/streaming/src/test/scala/org/apache/spark/streaming/util/RateLimitedOutputStreamSuite.scala @@ -36,8 +36,9 @@ class RateLimitedOutputStreamSuite extends FunSuite { val stream = new RateLimitedOutputStream(underlying, desiredBytesPerSec = 10000) val elapsedNs = benchmark { stream.write(data.getBytes("UTF-8")) } - // We accept anywhere from 4.0 to 4.99999 seconds since the value is rounded down. - assert(SECONDS.convert(elapsedNs, NANOSECONDS) === 4) + val seconds = SECONDS.convert(elapsedNs, NANOSECONDS) + assert(seconds >= 4, s"Seconds value ($seconds) is less than 4.") + assert(seconds <= 30, s"Took more than 30 seconds ($seconds) to write data.") assert(underlying.toString("UTF-8") === data) } } |