aboutsummaryrefslogtreecommitdiff
path: root/unsafe
diff options
context:
space:
mode:
authorReynold Xin <rxin@databricks.com>2015-08-11 08:41:06 -0700
committerDavies Liu <davies.liu@gmail.com>2015-08-11 08:41:06 -0700
commitd378396f86f625f006738d87fe5dbc2ff8fd913d (patch)
tree488e09f59d69d52f776b7587c9c0afead051b541 /unsafe
parent600031ebe27473d8fffe6ea436c2149223b82896 (diff)
downloadspark-d378396f86f625f006738d87fe5dbc2ff8fd913d.tar.gz
spark-d378396f86f625f006738d87fe5dbc2ff8fd913d.tar.bz2
spark-d378396f86f625f006738d87fe5dbc2ff8fd913d.zip
[SPARK-9815] Rename PlatformDependent.UNSAFE -> Platform.
PlatformDependent.UNSAFE is way too verbose. Author: Reynold Xin <rxin@databricks.com> Closes #8094 from rxin/SPARK-9815 and squashes the following commits: 229b603 [Reynold Xin] [SPARK-9815] Rename PlatformDependent.UNSAFE -> Platform.
Diffstat (limited to 'unsafe')
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/Platform.java (renamed from unsafe/src/main/java/org/apache/spark/unsafe/PlatformDependent.java)170
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java14
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java6
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java19
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java4
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java4
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java6
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java10
-rw-r--r--unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java30
-rw-r--r--unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java14
10 files changed, 124 insertions, 153 deletions
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/PlatformDependent.java b/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
index b2de2a2590..18343efdc3 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/PlatformDependent.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
@@ -22,103 +22,111 @@ import java.math.BigInteger;
import sun.misc.Unsafe;
-public final class PlatformDependent {
+public final class Platform {
- /**
- * Facade in front of {@link sun.misc.Unsafe}, used to avoid directly exposing Unsafe outside of
- * this package. This also lets us avoid accidental use of deprecated methods.
- */
- public static final class UNSAFE {
-
- private UNSAFE() { }
+ private static final Unsafe _UNSAFE;
- public static int getInt(Object object, long offset) {
- return _UNSAFE.getInt(object, offset);
- }
+ public static final int BYTE_ARRAY_OFFSET;
- public static void putInt(Object object, long offset, int value) {
- _UNSAFE.putInt(object, offset, value);
- }
+ public static final int INT_ARRAY_OFFSET;
- public static boolean getBoolean(Object object, long offset) {
- return _UNSAFE.getBoolean(object, offset);
- }
+ public static final int LONG_ARRAY_OFFSET;
- public static void putBoolean(Object object, long offset, boolean value) {
- _UNSAFE.putBoolean(object, offset, value);
- }
+ public static final int DOUBLE_ARRAY_OFFSET;
- public static byte getByte(Object object, long offset) {
- return _UNSAFE.getByte(object, offset);
- }
+ // Support for resetting final fields while deserializing
+ public static final long BIG_INTEGER_SIGNUM_OFFSET;
+ public static final long BIG_INTEGER_MAG_OFFSET;
- public static void putByte(Object object, long offset, byte value) {
- _UNSAFE.putByte(object, offset, value);
- }
+ public static int getInt(Object object, long offset) {
+ return _UNSAFE.getInt(object, offset);
+ }
- public static short getShort(Object object, long offset) {
- return _UNSAFE.getShort(object, offset);
- }
+ public static void putInt(Object object, long offset, int value) {
+ _UNSAFE.putInt(object, offset, value);
+ }
- public static void putShort(Object object, long offset, short value) {
- _UNSAFE.putShort(object, offset, value);
- }
+ public static boolean getBoolean(Object object, long offset) {
+ return _UNSAFE.getBoolean(object, offset);
+ }
- public static long getLong(Object object, long offset) {
- return _UNSAFE.getLong(object, offset);
- }
+ public static void putBoolean(Object object, long offset, boolean value) {
+ _UNSAFE.putBoolean(object, offset, value);
+ }
- public static void putLong(Object object, long offset, long value) {
- _UNSAFE.putLong(object, offset, value);
- }
+ public static byte getByte(Object object, long offset) {
+ return _UNSAFE.getByte(object, offset);
+ }
- public static float getFloat(Object object, long offset) {
- return _UNSAFE.getFloat(object, offset);
- }
+ public static void putByte(Object object, long offset, byte value) {
+ _UNSAFE.putByte(object, offset, value);
+ }
- public static void putFloat(Object object, long offset, float value) {
- _UNSAFE.putFloat(object, offset, value);
- }
+ public static short getShort(Object object, long offset) {
+ return _UNSAFE.getShort(object, offset);
+ }
- public static double getDouble(Object object, long offset) {
- return _UNSAFE.getDouble(object, offset);
- }
+ public static void putShort(Object object, long offset, short value) {
+ _UNSAFE.putShort(object, offset, value);
+ }
- public static void putDouble(Object object, long offset, double value) {
- _UNSAFE.putDouble(object, offset, value);
- }
+ public static long getLong(Object object, long offset) {
+ return _UNSAFE.getLong(object, offset);
+ }
- public static Object getObjectVolatile(Object object, long offset) {
- return _UNSAFE.getObjectVolatile(object, offset);
- }
+ public static void putLong(Object object, long offset, long value) {
+ _UNSAFE.putLong(object, offset, value);
+ }
- public static void putObjectVolatile(Object object, long offset, Object value) {
- _UNSAFE.putObjectVolatile(object, offset, value);
- }
+ public static float getFloat(Object object, long offset) {
+ return _UNSAFE.getFloat(object, offset);
+ }
- public static long allocateMemory(long size) {
- return _UNSAFE.allocateMemory(size);
- }
+ public static void putFloat(Object object, long offset, float value) {
+ _UNSAFE.putFloat(object, offset, value);
+ }
- public static void freeMemory(long address) {
- _UNSAFE.freeMemory(address);
- }
+ public static double getDouble(Object object, long offset) {
+ return _UNSAFE.getDouble(object, offset);
+ }
+ public static void putDouble(Object object, long offset, double value) {
+ _UNSAFE.putDouble(object, offset, value);
}
- private static final Unsafe _UNSAFE;
+ public static Object getObjectVolatile(Object object, long offset) {
+ return _UNSAFE.getObjectVolatile(object, offset);
+ }
- public static final int BYTE_ARRAY_OFFSET;
+ public static void putObjectVolatile(Object object, long offset, Object value) {
+ _UNSAFE.putObjectVolatile(object, offset, value);
+ }
- public static final int INT_ARRAY_OFFSET;
+ public static long allocateMemory(long size) {
+ return _UNSAFE.allocateMemory(size);
+ }
- public static final int LONG_ARRAY_OFFSET;
+ public static void freeMemory(long address) {
+ _UNSAFE.freeMemory(address);
+ }
- public static final int DOUBLE_ARRAY_OFFSET;
+ public static void copyMemory(
+ Object src, long srcOffset, Object dst, long dstOffset, long length) {
+ while (length > 0) {
+ long size = Math.min(length, UNSAFE_COPY_THRESHOLD);
+ _UNSAFE.copyMemory(src, srcOffset, dst, dstOffset, size);
+ length -= size;
+ srcOffset += size;
+ dstOffset += size;
+ }
+ }
- // Support for resetting final fields while deserializing
- public static final long BIG_INTEGER_SIGNUM_OFFSET;
- public static final long BIG_INTEGER_MAG_OFFSET;
+ /**
+ * Raises an exception bypassing compiler checks for checked exceptions.
+ */
+ public static void throwException(Throwable t) {
+ _UNSAFE.throwException(t);
+ }
/**
* Limits the number of bytes to copy per {@link Unsafe#copyMemory(long, long, long)} to
@@ -162,26 +170,4 @@ public final class PlatformDependent {
BIG_INTEGER_MAG_OFFSET = 0;
}
}
-
- static public void copyMemory(
- Object src,
- long srcOffset,
- Object dst,
- long dstOffset,
- long length) {
- while (length > 0) {
- long size = Math.min(length, UNSAFE_COPY_THRESHOLD);
- _UNSAFE.copyMemory(src, srcOffset, dst, dstOffset, size);
- length -= size;
- srcOffset += size;
- dstOffset += size;
- }
- }
-
- /**
- * Raises an exception bypassing compiler checks for checked exceptions.
- */
- public static void throwException(Throwable t) {
- _UNSAFE.throwException(t);
- }
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java b/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
index 70b81ce015..cf42877bf9 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.array;
-import static org.apache.spark.unsafe.PlatformDependent.*;
+import org.apache.spark.unsafe.Platform;
public class ByteArrayMethods {
@@ -45,20 +45,18 @@ public class ByteArrayMethods {
* @return true if the arrays are equal, false otherwise
*/
public static boolean arrayEquals(
- Object leftBase,
- long leftOffset,
- Object rightBase,
- long rightOffset,
- final long length) {
+ Object leftBase, long leftOffset, Object rightBase, long rightOffset, final long length) {
int i = 0;
while (i <= length - 8) {
- if (UNSAFE.getLong(leftBase, leftOffset + i) != UNSAFE.getLong(rightBase, rightOffset + i)) {
+ if (Platform.getLong(leftBase, leftOffset + i) !=
+ Platform.getLong(rightBase, rightOffset + i)) {
return false;
}
i += 8;
}
while (i < length) {
- if (UNSAFE.getByte(leftBase, leftOffset + i) != UNSAFE.getByte(rightBase, rightOffset + i)) {
+ if (Platform.getByte(leftBase, leftOffset + i) !=
+ Platform.getByte(rightBase, rightOffset + i)) {
return false;
}
i += 1;
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java b/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java
index 18d1f0d2d7..74105050e4 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/array/LongArray.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.array;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
import org.apache.spark.unsafe.memory.MemoryBlock;
/**
@@ -64,7 +64,7 @@ public final class LongArray {
public void set(int index, long value) {
assert index >= 0 : "index (" + index + ") should >= 0";
assert index < length : "index (" + index + ") should < length (" + length + ")";
- PlatformDependent.UNSAFE.putLong(baseObj, baseOffset + index * WIDTH, value);
+ Platform.putLong(baseObj, baseOffset + index * WIDTH, value);
}
/**
@@ -73,6 +73,6 @@ public final class LongArray {
public long get(int index) {
assert index >= 0 : "index (" + index + ") should >= 0";
assert index < length : "index (" + index + ") should < length (" + length + ")";
- return PlatformDependent.UNSAFE.getLong(baseObj, baseOffset + index * WIDTH);
+ return Platform.getLong(baseObj, baseOffset + index * WIDTH);
}
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java b/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java
index 27462c7fa5..7857bf66a7 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/bitset/BitSetMethods.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.bitset;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
/**
* Methods for working with fixed-size uncompressed bitsets.
@@ -41,8 +41,8 @@ public final class BitSetMethods {
assert index >= 0 : "index (" + index + ") should >= 0";
final long mask = 1L << (index & 0x3f); // mod 64 and shift
final long wordOffset = baseOffset + (index >> 6) * WORD_SIZE;
- final long word = PlatformDependent.UNSAFE.getLong(baseObject, wordOffset);
- PlatformDependent.UNSAFE.putLong(baseObject, wordOffset, word | mask);
+ final long word = Platform.getLong(baseObject, wordOffset);
+ Platform.putLong(baseObject, wordOffset, word | mask);
}
/**
@@ -52,8 +52,8 @@ public final class BitSetMethods {
assert index >= 0 : "index (" + index + ") should >= 0";
final long mask = 1L << (index & 0x3f); // mod 64 and shift
final long wordOffset = baseOffset + (index >> 6) * WORD_SIZE;
- final long word = PlatformDependent.UNSAFE.getLong(baseObject, wordOffset);
- PlatformDependent.UNSAFE.putLong(baseObject, wordOffset, word & ~mask);
+ final long word = Platform.getLong(baseObject, wordOffset);
+ Platform.putLong(baseObject, wordOffset, word & ~mask);
}
/**
@@ -63,7 +63,7 @@ public final class BitSetMethods {
assert index >= 0 : "index (" + index + ") should >= 0";
final long mask = 1L << (index & 0x3f); // mod 64 and shift
final long wordOffset = baseOffset + (index >> 6) * WORD_SIZE;
- final long word = PlatformDependent.UNSAFE.getLong(baseObject, wordOffset);
+ final long word = Platform.getLong(baseObject, wordOffset);
return (word & mask) != 0;
}
@@ -73,7 +73,7 @@ public final class BitSetMethods {
public static boolean anySet(Object baseObject, long baseOffset, long bitSetWidthInWords) {
long addr = baseOffset;
for (int i = 0; i < bitSetWidthInWords; i++, addr += WORD_SIZE) {
- if (PlatformDependent.UNSAFE.getLong(baseObject, addr) != 0) {
+ if (Platform.getLong(baseObject, addr) != 0) {
return true;
}
}
@@ -109,8 +109,7 @@ public final class BitSetMethods {
// Try to find the next set bit in the current word
final int subIndex = fromIndex & 0x3f;
- long word =
- PlatformDependent.UNSAFE.getLong(baseObject, baseOffset + wi * WORD_SIZE) >> subIndex;
+ long word = Platform.getLong(baseObject, baseOffset + wi * WORD_SIZE) >> subIndex;
if (word != 0) {
return (wi << 6) + subIndex + java.lang.Long.numberOfTrailingZeros(word);
}
@@ -118,7 +117,7 @@ public final class BitSetMethods {
// Find the next set bit in the rest of the words
wi += 1;
while (wi < bitsetSizeInWords) {
- word = PlatformDependent.UNSAFE.getLong(baseObject, baseOffset + wi * WORD_SIZE);
+ word = Platform.getLong(baseObject, baseOffset + wi * WORD_SIZE);
if (word != 0) {
return (wi << 6) + java.lang.Long.numberOfTrailingZeros(word);
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java b/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java
index 61f483ced3..4276f25c21 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/hash/Murmur3_x86_32.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.hash;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
/**
* 32-bit Murmur3 hasher. This is based on Guava's Murmur3_32HashFunction.
@@ -53,7 +53,7 @@ public final class Murmur3_x86_32 {
assert (lengthInBytes % 8 == 0): "lengthInBytes must be a multiple of 8 (word-aligned)";
int h1 = seed;
for (int i = 0; i < lengthInBytes; i += 4) {
- int halfWord = PlatformDependent.UNSAFE.getInt(base, offset + i);
+ int halfWord = Platform.getInt(base, offset + i);
int k1 = mixK1(halfWord);
h1 = mixH1(h1, k1);
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java b/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java
index 91be46ba21..dd75820834 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/memory/MemoryBlock.java
@@ -19,7 +19,7 @@ package org.apache.spark.unsafe.memory;
import javax.annotation.Nullable;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
/**
* A consecutive block of memory, starting at a {@link MemoryLocation} with a fixed size.
@@ -50,6 +50,6 @@ public class MemoryBlock extends MemoryLocation {
* Creates a memory block pointing to the memory used by the long array.
*/
public static MemoryBlock fromLongArray(final long[] array) {
- return new MemoryBlock(array, PlatformDependent.LONG_ARRAY_OFFSET, array.length * 8);
+ return new MemoryBlock(array, Platform.LONG_ARRAY_OFFSET, array.length * 8);
}
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java b/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
index 62f4459696..cda7826c8c 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/memory/UnsafeMemoryAllocator.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.memory;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
/**
* A simple {@link MemoryAllocator} that uses {@code Unsafe} to allocate off-heap memory.
@@ -29,7 +29,7 @@ public class UnsafeMemoryAllocator implements MemoryAllocator {
if (size % 8 != 0) {
throw new IllegalArgumentException("Size " + size + " was not a multiple of 8");
}
- long address = PlatformDependent.UNSAFE.allocateMemory(size);
+ long address = Platform.allocateMemory(size);
return new MemoryBlock(null, address, size);
}
@@ -37,6 +37,6 @@ public class UnsafeMemoryAllocator implements MemoryAllocator {
public void free(MemoryBlock memory) {
assert (memory.obj == null) :
"baseObject not null; are you trying to use the off-heap allocator to free on-heap memory?";
- PlatformDependent.UNSAFE.freeMemory(memory.offset);
+ Platform.freeMemory(memory.offset);
}
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java b/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java
index 69b0e206ce..c08c9c73d2 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/types/ByteArray.java
@@ -17,7 +17,7 @@
package org.apache.spark.unsafe.types;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
public class ByteArray {
@@ -27,12 +27,6 @@ public class ByteArray {
* hold all the bytes in this string.
*/
public static void writeToMemory(byte[] src, Object target, long targetOffset) {
- PlatformDependent.copyMemory(
- src,
- PlatformDependent.BYTE_ARRAY_OFFSET,
- target,
- targetOffset,
- src.length
- );
+ Platform.copyMemory(src, Platform.BYTE_ARRAY_OFFSET, target, targetOffset, src.length);
}
}
diff --git a/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java b/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
index d1014426c0..667c00900f 100644
--- a/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
+++ b/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
@@ -24,10 +24,10 @@ import java.nio.ByteOrder;
import java.util.Arrays;
import java.util.Map;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
import org.apache.spark.unsafe.array.ByteArrayMethods;
-import static org.apache.spark.unsafe.PlatformDependent.*;
+import static org.apache.spark.unsafe.Platform.*;
/**
@@ -133,13 +133,7 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
* bytes in this string.
*/
public void writeToMemory(Object target, long targetOffset) {
- PlatformDependent.copyMemory(
- base,
- offset,
- target,
- targetOffset,
- numBytes
- );
+ Platform.copyMemory(base, offset, target, targetOffset, numBytes);
}
/**
@@ -183,12 +177,12 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
long mask = 0;
if (isLittleEndian) {
if (numBytes >= 8) {
- p = PlatformDependent.UNSAFE.getLong(base, offset);
+ p = Platform.getLong(base, offset);
} else if (numBytes > 4) {
- p = PlatformDependent.UNSAFE.getLong(base, offset);
+ p = Platform.getLong(base, offset);
mask = (1L << (8 - numBytes) * 8) - 1;
} else if (numBytes > 0) {
- p = (long) PlatformDependent.UNSAFE.getInt(base, offset);
+ p = (long) Platform.getInt(base, offset);
mask = (1L << (8 - numBytes) * 8) - 1;
} else {
p = 0;
@@ -197,12 +191,12 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
} else {
// byteOrder == ByteOrder.BIG_ENDIAN
if (numBytes >= 8) {
- p = PlatformDependent.UNSAFE.getLong(base, offset);
+ p = Platform.getLong(base, offset);
} else if (numBytes > 4) {
- p = PlatformDependent.UNSAFE.getLong(base, offset);
+ p = Platform.getLong(base, offset);
mask = (1L << (8 - numBytes) * 8) - 1;
} else if (numBytes > 0) {
- p = ((long) PlatformDependent.UNSAFE.getInt(base, offset)) << 32;
+ p = ((long) Platform.getInt(base, offset)) << 32;
mask = (1L << (8 - numBytes) * 8) - 1;
} else {
p = 0;
@@ -293,7 +287,7 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
* Returns the byte at position `i`.
*/
private byte getByte(int i) {
- return UNSAFE.getByte(base, offset + i);
+ return Platform.getByte(base, offset + i);
}
private boolean matchAt(final UTF8String s, int pos) {
@@ -769,7 +763,7 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
int len = inputs[i].numBytes;
copyMemory(
inputs[i].base, inputs[i].offset,
- result, PlatformDependent.BYTE_ARRAY_OFFSET + offset,
+ result, BYTE_ARRAY_OFFSET + offset,
len);
offset += len;
@@ -778,7 +772,7 @@ public final class UTF8String implements Comparable<UTF8String>, Serializable {
if (j < numInputs) {
copyMemory(
separator.base, separator.offset,
- result, PlatformDependent.BYTE_ARRAY_OFFSET + offset,
+ result, BYTE_ARRAY_OFFSET + offset,
separator.numBytes);
offset += separator.numBytes;
}
diff --git a/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java b/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
index 3b91758352..2f8cb132ac 100644
--- a/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
+++ b/unsafe/src/test/java/org/apache/spark/unsafe/hash/Murmur3_x86_32Suite.java
@@ -22,7 +22,7 @@ import java.util.Random;
import java.util.Set;
import junit.framework.Assert;
-import org.apache.spark.unsafe.PlatformDependent;
+import org.apache.spark.unsafe.Platform;
import org.junit.Test;
/**
@@ -83,11 +83,11 @@ public class Murmur3_x86_32Suite {
rand.nextBytes(bytes);
Assert.assertEquals(
- hasher.hashUnsafeWords(bytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize),
- hasher.hashUnsafeWords(bytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize));
+ hasher.hashUnsafeWords(bytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize),
+ hasher.hashUnsafeWords(bytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize));
hashcodes.add(hasher.hashUnsafeWords(
- bytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize));
+ bytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize));
}
// A very loose bound.
@@ -106,11 +106,11 @@ public class Murmur3_x86_32Suite {
System.arraycopy(strBytes, 0, paddedBytes, 0, strBytes.length);
Assert.assertEquals(
- hasher.hashUnsafeWords(paddedBytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize),
- hasher.hashUnsafeWords(paddedBytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize));
+ hasher.hashUnsafeWords(paddedBytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize),
+ hasher.hashUnsafeWords(paddedBytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize));
hashcodes.add(hasher.hashUnsafeWords(
- paddedBytes, PlatformDependent.BYTE_ARRAY_OFFSET, byteArrSize));
+ paddedBytes, Platform.BYTE_ARRAY_OFFSET, byteArrSize));
}
// A very loose bound.