aboutsummaryrefslogtreecommitdiff
path: root/yarn/stable/src
diff options
context:
space:
mode:
authorKay Ousterhout <kayousterhout@gmail.com>2014-04-08 01:03:33 -0700
committerKay Ousterhout <kayousterhout@gmail.com>2014-04-08 01:03:33 -0700
commit6dc5f5849c0e0378abc6648c919412827d831641 (patch)
treeb8ed2cf808a8f11e802622e762091fed3c1c28a8 /yarn/stable/src
parent83ac9a4bbf272028d0c4639cbd1e12022b9ae77a (diff)
downloadspark-6dc5f5849c0e0378abc6648c919412827d831641.tar.gz
spark-6dc5f5849c0e0378abc6648c919412827d831641.tar.bz2
spark-6dc5f5849c0e0378abc6648c919412827d831641.zip
[SPARK-1396] Properly cleanup DAGScheduler on job cancellation.
Previously, when jobs were cancelled, not all of the state in the DAGScheduler was cleaned up, leading to a slow memory leak in the DAGScheduler. As we expose easier ways to cancel jobs, it's more important to fix these issues. This commit also fixes a second and less serious problem, which is that previously, when a stage failed, not all of the appropriate stages were cancelled. See the "failure of stage used by two jobs" test for an example of this. This just meant that extra work was done, and is not a correctness problem. This commit adds 3 tests. “run shuffle with map stage failure” is a new test to more thoroughly test this functionality, and passes on both the old and new versions of the code. “trivial job cancellation” fails on the old code because all state wasn’t cleaned up correctly when jobs were cancelled (we didn’t remove the job from resultStageToJob). “failure of stage used by two jobs” fails on the old code because taskScheduler.cancelTasks wasn’t called for one of the stages (see test comments). This should be checked in before #246, which makes it easier to cancel stages / jobs. Author: Kay Ousterhout <kayousterhout@gmail.com> Closes #305 from kayousterhout/incremental_abort_fix and squashes the following commits: f33d844 [Kay Ousterhout] Mark review comments 9217080 [Kay Ousterhout] Properly cleanup DAGScheduler on job cancellation.
Diffstat (limited to 'yarn/stable/src')
0 files changed, 0 insertions, 0 deletions