aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOmar Alejandro Mainegra Sarduy <omainegra@gmail.com>2017-08-01 11:05:56 -0400
committerOmar Alejandro Mainegra Sarduy <omainegra@gmail.com>2017-08-01 11:05:56 -0400
commit8d24a1653a21fd009075700de722e97fc40e7e00 (patch)
tree3eef78faa736c3c56a51a5cb05e718afdf59db8d
parentb3553253b68899c89bed44ac1c5eacc421a81eeb (diff)
downloadsttp-8d24a1653a21fd009075700de722e97fc40e7e00.tar.gz
sttp-8d24a1653a21fd009075700de722e97fc40e7e00.tar.bz2
sttp-8d24a1653a21fd009075700de722e97fc40e7e00.zip
Update with PR comments
-rw-r--r--README.md3
-rw-r--r--okhttp-client-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala12
2 files changed, 9 insertions, 6 deletions
diff --git a/README.md b/README.md
index 8d6dc24..5e091f4 100644
--- a/README.md
+++ b/README.md
@@ -402,4 +402,5 @@ and pick a task you'd like to work on!
## Credits
* [Tomasz SzymaƄski](https://github.com/szimano)
-* [Adam Warski](https://github.com/adamw) \ No newline at end of file
+* [Adam Warski](https://github.com/adamw)
+* [Omar Alejandro Mainegra Sarduy](https://github.com/omainegra) \ No newline at end of file
diff --git a/okhttp-client-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala b/okhttp-client-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala
index 2ac1312..99f0770 100644
--- a/okhttp-client-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala
+++ b/okhttp-client-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala
@@ -35,9 +35,11 @@ abstract class OkHttpClientHandler[R[_], S](client: OkHttpClient)
})
//OkHttp support automatic gzip compression
- request.headers.filter(_._1 != "Accept-Encoding").foreach {
- case (name, value) => builder.addHeader(name, value)
- }
+ request.headers
+ .filter(_._1.equalsIgnoreCase(AcceptEncodingHeader) == false)
+ .foreach {
+ case (name, value) => builder.addHeader(name, value)
+ }
builder.build()
}
@@ -74,8 +76,8 @@ abstract class OkHttpClientHandler[R[_], S](client: OkHttpClient)
Response(body, res.code(), headers.toList)
}
- private[okhttp] def readResponseBody[T](res: OkHttpResponse,
- responseAs: ResponseAs[T, S]): T = {
+ private def readResponseBody[T](res: OkHttpResponse,
+ responseAs: ResponseAs[T, S]): T = {
responseAs match {
case IgnoreResponse => res.body().close()
case ResponseAsString(encoding) =>