diff options
author | adamw <adam@warski.org> | 2017-09-04 12:09:06 +0200 |
---|---|---|
committer | adamw <adam@warski.org> | 2017-09-04 12:09:06 +0200 |
commit | 97571ff137dbb505e94ccf65ce49af7de68690ad (patch) | |
tree | 003c6dbca85f4b58b8b964a8cb345751fab22e29 | |
parent | d1bcec26f1cdd0d40fa61ef5bbf91d8a6513bb43 (diff) | |
download | sttp-97571ff137dbb505e94ccf65ce49af7de68690ad.tar.gz sttp-97571ff137dbb505e94ccf65ce49af7de68690ad.tar.bz2 sttp-97571ff137dbb505e94ccf65ce49af7de68690ad.zip |
All handler must implement close() (even if empty)
3 files changed, 5 insertions, 1 deletions
diff --git a/core/src/main/scala/com/softwaremill/sttp/HttpURLConnectionHandler.scala b/core/src/main/scala/com/softwaremill/sttp/HttpURLConnectionHandler.scala index 24c93f4..ab10261 100644 --- a/core/src/main/scala/com/softwaremill/sttp/HttpURLConnectionHandler.scala +++ b/core/src/main/scala/com/softwaremill/sttp/HttpURLConnectionHandler.scala @@ -244,4 +244,6 @@ object HttpURLConnectionHandler extends SttpHandler[Id, Nothing] { case Some(ce) => throw new UnsupportedEncodingException(s"Unsupported encoding: $ce") } + + override def close(): Unit = {} } diff --git a/core/src/main/scala/com/softwaremill/sttp/SttpHandler.scala b/core/src/main/scala/com/softwaremill/sttp/SttpHandler.scala index f52eef6..cc34102 100644 --- a/core/src/main/scala/com/softwaremill/sttp/SttpHandler.scala +++ b/core/src/main/scala/com/softwaremill/sttp/SttpHandler.scala @@ -68,7 +68,7 @@ trait SttpHandler[R[_], -S] { } } - def close(): Unit = {} + def close(): Unit protected def doSend[T](request: Request[T, S]): R[Response[T]] diff --git a/okhttp-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala b/okhttp-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala index 295ca2a..5574417 100644 --- a/okhttp-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala +++ b/okhttp-handler/src/main/scala/com/softwaremill/sttp/okhttp/OkHttpClientHandler.scala @@ -134,6 +134,8 @@ abstract class OkHttpHandler[R[_], S](client: OkHttpClient) def responseBodyToStream(res: OkHttpResponse): Try[S] = Failure(new IllegalStateException("Streaming isn't supported")) + + override def close(): Unit = {} } object OkHttpHandler { |