navigator/geofence: move more functions to geofence class (WIP)

1 files changed, 14 insertions, 113 deletions

diff --git a/src/modules/navigator/navigator_main.cpp b/src/modules/navigator/navigator_main.cpp
index a9547355f..354fa733b 100644
--- a/src/modules/navigator/navigator_main.cpp
+++ b/src/modules/navigator/navigator_main.cpp
@@ -120,14 +120,9 @@ public:
 	void		status();
 
 	/**
-	 * Load fence parameters.
+	 * Add point to geofence
 	 */
-	bool		load_fence(unsigned vertices);
-
-	/**
-	 * Specify fence vertex position.
-	 */
-	void		fence_point(int argc, char *argv[]);
+	void add_fence_point(int argc, char *argv[]);
 
 private:
 
@@ -145,7 +140,6 @@ private:
 	int		_capabilities_sub;		/**< notification of vehicle capabilities updates */
 
 	orb_advert_t	_triplet_pub;			/**< publish position setpoint triplet */
-	orb_advert_t	_fence_pub;			/**< publish fence topic */ 
 	orb_advert_t	_mission_result_pub;		/**< publish mission result topic */
 	orb_advert_t	_control_mode_pub;			/**< publish vehicle control mode topic */
 
@@ -158,8 +152,7 @@ private:
 
 	perf_counter_t	_loop_perf;			/**< loop performance counter */
 	
-	Geofence					geofence;
-	struct fence_s 					_fence;			/**< storage for fence vertices */
+	Geofence					_geofence;
 	bool						_fence_valid;		/**< flag if fence is valid */
         bool						_inside_fence;		/**< vehicle is inside fence */
 
@@ -252,12 +245,8 @@ private:
 	 */
 	void		task_main() __attribute__((noreturn));
 
-	void		publish_fence(unsigned vertices);
-
 	void		publish_safepoints(unsigned points);
 
-	bool		fence_valid(const struct fence_s &fence);
-
 	/**
 	 * Functions that are triggered when a new state is entered.
 	 */
@@ -347,7 +336,6 @@ Navigator::Navigator() :
 
 /* publications */
 	_triplet_pub(-1),
-	_fence_pub(-1),
 	_mission_result_pub(-1),
 	_control_mode_pub(-1),
 
@@ -365,8 +353,6 @@ Navigator::Navigator() :
 	_time_first_inside_orbit(0),
 	_set_nav_state_timestamp(0)
 {
-	memset(&_fence, 0, sizeof(_fence));
-
 	_parameter_handles.min_altitude = param_find("NAV_MIN_ALT");
 	_parameter_handles.loiter_radius = param_find("NAV_LOITER_RAD");
 	_parameter_handles.onboard_mission_enabled = param_find("NAV_ONB_MIS_EN");
@@ -458,7 +444,7 @@ Navigator::offboard_mission_update(bool isrotaryWing)
 		} else {
 			dm_current = DM_KEY_WAYPOINTS_OFFBOARD_1;
 		}
-		missionFeasiblityChecker.checkMissionFeasible(isrotaryWing, dm_current, (size_t)offboard_mission.count, _fence);
+		missionFeasiblityChecker.checkMissionFeasible(isrotaryWing, dm_current, (size_t)offboard_mission.count, _geofence);
 
 		_mission.set_offboard_dataman_id(offboard_mission.dataman_id);
 		_mission.set_current_offboard_mission_index(offboard_mission.current_index);
@@ -511,7 +497,7 @@ Navigator::task_main()
 
 	mavlink_log_info(_mavlink_fd, "[navigator] started");
 
-	_fence_valid = load_fence(GEOFENCE_MAX_VERTICES);
+	_fence_valid = _geofence.load(GEOFENCE_MAX_VERTICES);
 
 	/*
 	 * do subscriptions
@@ -782,9 +768,9 @@ Navigator::status()
 	}
 	if (_fence_valid) {
 		warnx("Geofence is valid");
-		warnx("Vertex longitude latitude");
-		for (unsigned i = 0; i < _fence.count; i++)
-		warnx("%6u %9.5f %8.5f", i, (double)_fence.vertices[i].lon, (double)_fence.vertices[i].lat);
+//		warnx("Vertex longitude latitude");
+//		for (unsigned i = 0; i < _fence.count; i++)
+//		warnx("%6u %9.5f %8.5f", i, (double)_fence.vertices[i].lon, (double)_fence.vertices[i].lat);
 	} else {
 		warnx("Geofence not set");
 	}
@@ -808,96 +794,6 @@ Navigator::status()
 	}
 }
 
-void
-Navigator::publish_fence(unsigned vertices)
-{
-	if (_fence_pub == -1)
-		_fence_pub = orb_advertise(ORB_ID(fence), &vertices);
-	else
-		orb_publish(ORB_ID(fence), _fence_pub, &vertices);
-}
-
-bool
-Navigator::fence_valid(const struct fence_s &fence)
-{
-	// NULL fence is valid
-	if (fence.count == 0) {
-		return true;
-	}
-
-	// Otherwise
-	if ((fence.count < 4) || (fence.count > GEOFENCE_MAX_VERTICES)) {
-		warnx("Fence must have at least 3 sides and not more than %d", GEOFENCE_MAX_VERTICES - 1);
-		return false;
-	}
-
-	return true;
-}
-
-bool
-Navigator::load_fence(unsigned vertices)
-{
-	struct fence_s temp_fence;
-
-	unsigned i;
-	for (i = 0; i < vertices; i++) {
-		if (dm_read(DM_KEY_FENCE_POINTS, i, temp_fence.vertices + i, sizeof(struct fence_vertex_s)) != sizeof(struct fence_vertex_s)) {
-			break;
-		}
-	}
-
-	temp_fence.count = i;
-
-	if (fence_valid(temp_fence))
-		memcpy(&_fence, &temp_fence, sizeof(_fence));
-	else
-		warnx("Invalid fence file, ignored!");
-
-	return _fence.count != 0;
-}
-
-void
-Navigator::fence_point(int argc, char *argv[])
-{
-	int ix, last;
-	double lon, lat;
-	struct fence_vertex_s vertex;
-	char *end;
-
-	if ((argc == 1) && (strcmp("-clear", argv[0]) == 0)) {
-		dm_clear(DM_KEY_FENCE_POINTS);
-		publish_fence(0);
-		return;
-	}
-
-	if (argc < 3)
-		errx(1, "Specify: -clear | sequence latitude longitude [-publish]");
-
-	ix = atoi(argv[0]);
-	if (ix >= DM_KEY_FENCE_POINTS_MAX)
-		errx(1, "Sequence must be less than %d", DM_KEY_FENCE_POINTS_MAX);
-
-	lat = strtod(argv[1], &end);
-	lon = strtod(argv[2], &end);
-
-	last = 0;
-	if ((argc > 3) && (strcmp(argv[3], "-publish") == 0))
-		last = 1;
-
-	vertex.lat = (float)lat;
-	vertex.lon = (float)lon;
-
-	if (dm_write(DM_KEY_FENCE_POINTS, ix, DM_PERSIST_POWER_ON_RESET, &vertex, sizeof(vertex)) == sizeof(vertex)) {
-		if (last)
-			publish_fence((unsigned)ix + 1);
-		return;
-	}
-
-	errx(1, "can't store fence point");
-}
-
-
-
 StateTable::Tran const Navigator::myTable[NAV_STATE_MAX][MAX_EVENT] = {
 	{	
 							/* STATE_NONE */
@@ -1351,6 +1247,11 @@ bool Navigator::cmp_mission_item_equivalent(const struct mission_item_s a, const
 	}
 }
 
+void Navigator::add_fence_point(int argc, char *argv[])
+{
+	_geofence.addPoint(argc, argv);
+}
+
 
 static void usage()
 {
@@ -1395,7 +1296,7 @@ int navigator_main(int argc, char *argv[])
 		navigator::g_navigator->status();
 
 	} else if (!strcmp(argv[1], "fence")) {
-		navigator::g_navigator->fence_point(argc - 2, argv + 2);
+		navigator::g_navigator->add_fence_point(argc - 2, argv + 2);
 
 	} else {
 		usage();