aboutsummaryrefslogtreecommitdiff
path: root/src/modules/px4iofirmware/registers.c
diff options
context:
space:
mode:
authorJulian Oes <julian@oes.ch>2013-10-07 16:24:49 +0200
committerJulian Oes <julian@oes.ch>2013-10-07 16:24:49 +0200
commitea0aa49b546476ef9ca9904b32dc507d66f0ab44 (patch)
treed881fb2714978efea6d1b0da827a8ecd438ba0d4 /src/modules/px4iofirmware/registers.c
parent9ff521711861fce857b6c17c2ec87eaa2073376e (diff)
downloadpx4-firmware-ea0aa49b546476ef9ca9904b32dc507d66f0ab44.tar.gz
px4-firmware-ea0aa49b546476ef9ca9904b32dc507d66f0ab44.tar.bz2
px4-firmware-ea0aa49b546476ef9ca9904b32dc507d66f0ab44.zip
pwm info provides more information, some fixes for setting rate/min/max/disarmed
Diffstat (limited to 'src/modules/px4iofirmware/registers.c')
-rw-r--r--src/modules/px4iofirmware/registers.c55
1 files changed, 26 insertions, 29 deletions
diff --git a/src/modules/px4iofirmware/registers.c b/src/modules/px4iofirmware/registers.c
index 8cb21e54f..9d3c5ccfd 100644
--- a/src/modules/px4iofirmware/registers.c
+++ b/src/modules/px4iofirmware/registers.c
@@ -220,10 +220,10 @@ uint16_t r_page_servo_control_max[PX4IO_SERVO_COUNT] = { 2100, 2100, 2100, 2100
/**
* PAGE 108
*
- * idle PWM values for difficult ESCs
+ * disarmed PWM values for difficult ESCs
*
*/
-uint16_t r_page_servo_idle[PX4IO_SERVO_COUNT] = { 900, 900, 900, 900, 900, 900, 900, 900 };
+uint16_t r_page_servo_disarmed[PX4IO_SERVO_COUNT] = { 900, 900, 900, 900, 900, 900, 900, 900 };
int
registers_set(uint8_t page, uint8_t offset, const uint16_t *values, unsigned num_values)
@@ -293,16 +293,15 @@ registers_set(uint8_t page, uint8_t offset, const uint16_t *values, unsigned num
/* copy channel data */
while ((offset < PX4IO_SERVO_COUNT) && (num_values > 0)) {
- if (*values == 0)
- /* set to default */
- r_page_servo_control_min[offset] = 900;
-
- else if (*values > 1200)
+ if (*values == 0) {
+ /* ignore 0 */
+ } else if (*values > 1200) {
r_page_servo_control_min[offset] = 1200;
- else if (*values < 900)
+ } else if (*values < 900) {
r_page_servo_control_min[offset] = 900;
- else
+ } else {
r_page_servo_control_min[offset] = *values;
+ }
offset++;
num_values--;
@@ -315,16 +314,15 @@ registers_set(uint8_t page, uint8_t offset, const uint16_t *values, unsigned num
/* copy channel data */
while ((offset < PX4IO_SERVO_COUNT) && (num_values > 0)) {
- if (*values == 0)
- /* set to default */
- r_page_servo_control_max[offset] = 2100;
-
- else if (*values > 2100)
+ if (*values == 0) {
+ /* ignore 0 */
+ } else if (*values > 2100) {
r_page_servo_control_max[offset] = 2100;
- else if (*values < 1800)
+ } else if (*values < 1800) {
r_page_servo_control_max[offset] = 1800;
- else
+ } else {
r_page_servo_control_max[offset] = *values;
+ }
offset++;
num_values--;
@@ -332,21 +330,20 @@ registers_set(uint8_t page, uint8_t offset, const uint16_t *values, unsigned num
}
break;
- case PX4IO_PAGE_IDLE_PWM:
+ case PX4IO_PAGE_DISARMED_PWM:
/* copy channel data */
while ((offset < PX4IO_SERVO_COUNT) && (num_values > 0)) {
- if (*values == 0)
- /* set to default */
- r_page_servo_idle[offset] = 0;
-
- else if (*values < 900)
- r_page_servo_idle[offset] = 900;
- else if (*values > 2100)
- r_page_servo_idle[offset] = 2100;
- else
- r_page_servo_idle[offset] = *values;
+ if (*values == 0) {
+ /* ignore 0 */
+ } else if (*values < 900) {
+ r_page_servo_disarmed[offset] = 900;
+ } else if (*values > 2100) {
+ r_page_servo_disarmed[offset] = 2100;
+ } else {
+ r_page_servo_disarmed[offset] = *values;
+ }
/* flag the failsafe values as custom */
r_setup_arming |= PX4IO_P_SETUP_ARMING_ALWAYS_PWM_ENABLE;
@@ -769,8 +766,8 @@ registers_get(uint8_t page, uint8_t offset, uint16_t **values, unsigned *num_val
case PX4IO_PAGE_CONTROL_MAX_PWM:
SELECT_PAGE(r_page_servo_control_max);
break;
- case PX4IO_PAGE_IDLE_PWM:
- SELECT_PAGE(r_page_servo_idle);
+ case PX4IO_PAGE_DISARMED_PWM:
+ SELECT_PAGE(r_page_servo_disarmed);
break;
default: