diff options
author | Gregory Nutt <gnutt@nuttx.org> | 2014-07-06 09:08:38 -0600 |
---|---|---|
committer | Gregory Nutt <gnutt@nuttx.org> | 2014-07-06 09:08:38 -0600 |
commit | d28c7da6cba494cbc8a38708dec9f6d835d08074 (patch) | |
tree | 5b412d3ba5a184f6bc6df3da71f78761d3af8f23 | |
parent | 9ed66e6a680e7f9a89796357256b594eac43c459 (diff) | |
download | px4-nuttx-d28c7da6cba494cbc8a38708dec9f6d835d08074.tar.gz px4-nuttx-d28c7da6cba494cbc8a38708dec9f6d835d08074.tar.bz2 px4-nuttx-d28c7da6cba494cbc8a38708dec9f6d835d08074.zip |
maXTouch: Be consistent. Failure return values are not just non-zero, but negative
-rw-r--r-- | nuttx/drivers/input/mxt.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/nuttx/drivers/input/mxt.c b/nuttx/drivers/input/mxt.c index fd35ca071..4b6d37de3 100644 --- a/nuttx/drivers/input/mxt.c +++ b/nuttx/drivers/input/mxt.c @@ -1382,7 +1382,7 @@ static int mxt_getobjtab(FAR struct mxt_dev_s *priv) tabsize = priv->info.nobjects * sizeof(struct mxt_object_s); ret = mxt_getreg(priv, MXT_OBJECT_START, (FAR uint8_t *)priv->objtab, tabsize); - if (ret) + if (ret < 0) { return ret; } @@ -1507,7 +1507,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv) /* Get object table information */ ret = mxt_getobjtab(priv); - if (ret) + if (ret < 0) { goto errout_with_objtab; } @@ -1520,7 +1520,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv) /* Update matrix size in the info structure */ ret = mxt_getreg(priv, MXT_MATRIX_X_SIZE, (FAR uint8_t *)®val, 1); - if (ret) + if (ret < 0) { goto errout_with_objtab; } @@ -1528,7 +1528,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv) info->xsize = regval; ret = mxt_getreg(priv, MXT_MATRIX_Y_SIZE, (FAR uint8_t *)®val, 1); - if (ret) + if (ret < 0) { goto errout_with_objtab; } @@ -1577,7 +1577,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv) /* Force the CHG pin to the high state */ ret = mxt_chghigh(priv); - if (ret) + if (ret < 0) { goto errout_with_sample; } |