Make type creators work for erased types.

- Some types are different when erased (e.g. prefixes are NoPrefix)
- Some types are forbidden when erased. Put in assertions to check that fact.

Also, some renaming and doc comments to make creation of TermRefs and TypeRefs
clearer.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/dotty/tools/dotc/core/Denotations.scala b/src/dotty/tools/dotc/core/Denotations.scala
index fa2292c60..557c80b21 100644
--- a/src/dotty/tools/dotc/core/Denotations.scala
+++ b/src/dotty/tools/dotc/core/Denotations.scala
@@ -424,7 +424,7 @@ object Denotations {
      *  and at signature `NotAMethod`.
      */
     def valRef(implicit ctx: Context): TermRef =
-      TermRef.withSig(symbol.owner.thisType, symbol.name.asTermName, Signature.NotAMethod, this)
+      TermRef.withSigAndDenot(symbol.owner.thisType, symbol.name.asTermName, Signature.NotAMethod, this)
 
     /** The TermRef representing this term denotation at its original location
      *  at the denotation's signature.
@@ -432,7 +432,7 @@ object Denotations {
      *         denotation via a call to `info`.
      */
     def termRefWithSig(implicit ctx: Context): TermRef =
-      TermRef.withSig(symbol.owner.thisType, symbol.name.asTermName, signature, this)
+      TermRef.withSigAndDenot(symbol.owner.thisType, symbol.name.asTermName, signature, this)
 
     /** The NamedType representing this denotation at its original location.
      *  Same as either `typeRef` or `termRefWithSig` depending whether this denotes a type or not.