Upgraded handling of positions

It turned out the some trees were still carrying NoPosition in their pos fields. The new treatment avoids that and aslo adds some assertions to check for regressions.

1 files changed, 7 insertions, 1 deletions

diff --git a/src/dotty/tools/dotc/core/TyperState.scala b/src/dotty/tools/dotc/core/TyperState.scala
index 8fbd3502c..664655d7c 100644
--- a/src/dotty/tools/dotc/core/TyperState.scala
+++ b/src/dotty/tools/dotc/core/TyperState.scala
@@ -127,10 +127,16 @@ extends TyperState(reporter) {
 
   override def withCheckingDisabled[T](op: => T)(implicit ctx: Context): T = {
     val prev = enableChecking(false)
+    var thrown = false
     try op
+    catch {
+      case ex: Throwable =>
+        thrown = true
+        throw ex
+    }
     finally {
       enableChecking(prev)
-      checkConsistent
+      if (!thrown) checkConsistent
     }
   }