Move isSuppressed check from Reporter to ConsoleReporter.

isSuppressed forces computation of the error message; should be
called only when emitting the error.

TODO: Generalize so that other emitting reporters inherit the behavior.

1 files changed, 11 insertions, 10 deletions

diff --git a/src/dotty/tools/dotc/reporting/ConsoleReporter.scala b/src/dotty/tools/dotc/reporting/ConsoleReporter.scala
index 6991cdbb6..a7f7f70bb 100644
--- a/src/dotty/tools/dotc/reporting/ConsoleReporter.scala
+++ b/src/dotty/tools/dotc/reporting/ConsoleReporter.scala
@@ -40,16 +40,17 @@ class ConsoleReporter(
     }
   }
 
-  override def doReport(d: Diagnostic)(implicit ctx: Context): Unit = d match {
-    case d: Error =>
-      printMessageAndPos(s"error: ${d.msg}", d.pos)
-      if (ctx.settings.prompt.value) displayPrompt()
-    case d: ConditionalWarning if !d.enablingOption.value =>
-    case d: Warning =>
-      printMessageAndPos(s"warning: ${d.msg}", d.pos)
-    case _ =>
-      printMessageAndPos(d.msg, d.pos)
-  }
+  override def doReport(d: Diagnostic)(implicit ctx: Context): Unit =
+    if (!d.isSuppressed) d match {
+      case d: Error =>
+        printMessageAndPos(s"error: ${d.msg}", d.pos)
+        if (ctx.settings.prompt.value) displayPrompt()
+      case d: ConditionalWarning if !d.enablingOption.value =>
+      case d: Warning =>
+        printMessageAndPos(s"warning: ${d.msg}", d.pos)
+      case _ =>
+        printMessageAndPos(d.msg, d.pos)
+    }
 
   def displayPrompt(): Unit = {
     writer.print("\na)bort, s)tack, r)esume: ")