diff options
| author | Nathan Fischer <nfischer921@gmail.com> | 2019-04-10 14:26:35 -0700 |
|---|---|---|
| committer | Tobias Roeser <le.petit.fou@web.de> | 2019-04-17 08:06:46 +0200 |
| commit | e9bf4bc1867750d73346aa558ebcf885b8a5cdc5 (patch) | |
| tree | cd601959df2cca814369f3a2ed055d76208d0ed1 | |
| parent | 6abf903f63b6cbf178b435b958822d88e26df5a7 (diff) | |
| download | mill-e9bf4bc1867750d73346aa558ebcf885b8a5cdc5.tar.gz mill-e9bf4bc1867750d73346aa558ebcf885b8a5cdc5.tar.bz2 mill-e9bf4bc1867750d73346aa558ebcf885b8a5cdc5.zip | |
Reminder not to be bad
| -rw-r--r-- | contrib/flyway/src/FlywayModule.scala | 1 | ||||
| -rw-r--r-- | docs/pages/9 - Contrib Modules.md | 6 |
2 files changed, 6 insertions, 1 deletions
diff --git a/contrib/flyway/src/FlywayModule.scala b/contrib/flyway/src/FlywayModule.scala index f73e8e7b..0d4c3462 100644 --- a/contrib/flyway/src/FlywayModule.scala +++ b/contrib/flyway/src/FlywayModule.scala @@ -40,7 +40,6 @@ trait FlywayModule extends JavaModule { } .map(key -> _) - private implicit val flywayWriter = writer[String].comap[Flyway](_.toString) def flywayInstance = T.worker { val jdbcClassloader = new URLClassLoader(jdbcClasspath().map(_.path.toIO.toURI.toURL).toArray) diff --git a/docs/pages/9 - Contrib Modules.md b/docs/pages/9 - Contrib Modules.md index 2ce591d7..b979c677 100644 --- a/docs/pages/9 - Contrib Modules.md +++ b/docs/pages/9 - Contrib Modules.md @@ -63,12 +63,18 @@ Flyway will look for migration files in `db/migration` in all resources folders This should work regardless of if you are using a mill or sbt project layout. You can then run common flyway commands like + ``` mill foo.flywayClean mill foo.flywayInfo mill foo.flywayMigrate ``` +> REMINDER: +> You should never check credentials into any code or source control. +> You should write some code to populate the settings for flyway. +> For example `def flywayPassword = T.input(T.ctx().env("FLYWAY_PASSWORD"))` + ### Play Framework This module adds basic Play Framework support to mill: |