Ensure that transitive ivy jars are not directly aggregated under a module's `runClasspath`; only the ivy coordinates are aggregated, and every module resolves it's own set of ivy jars using coursier, which avoids duplicate jars entering the classpath through ivy

Fixes https://github.com/lihaoyi/mill/issues/211

1 files changed, 25 insertions, 0 deletions

diff --git a/scalalib/test/src/mill/scalalib/HelloWorldTests.scala b/scalalib/test/src/mill/scalalib/HelloWorldTests.scala
index 8b7c459f..74078221 100644
--- a/scalalib/test/src/mill/scalalib/HelloWorldTests.scala
+++ b/scalalib/test/src/mill/scalalib/HelloWorldTests.scala
@@ -87,6 +87,17 @@ object HelloWorldTests extends TestSuite {
       override def scalaVersion: Target[String] = "2.11.11"
     }
   }
+
+  object HelloWorldIvyDeps extends HelloBase{
+    object moduleA extends HelloWorldModule {
+
+      override def ivyDeps = Agg(ivy"com.lihaoyi::sourcecode:0.1.3")
+    }
+    object moduleB extends HelloWorldModule {
+      override def moduleDeps = Seq(moduleA)
+      override def ivyDeps = Agg(ivy"com.lihaoyi::sourcecode:0.1.4")
+    }
+  }
   val resourcePath = pwd / 'scalalib / 'test / 'resources / "hello-world"
 
   def jarMainClass(jar: JarFile): Option[String] = {
@@ -413,6 +424,20 @@ object HelloWorldTests extends TestSuite {
         )
       }
     }
+
+    'ivyDeps - workspaceTest(HelloWorldIvyDeps){ eval =>
+      val Right((result, _)) = eval.apply(HelloWorldIvyDeps.moduleA.runClasspath)
+      assert(
+        result.exists(_.path.last == "sourcecode_2.12-0.1.3.jar"),
+        !result.exists(_.path.last == "sourcecode_2.12-0.1.4.jar")
+      )
+
+      val Right((result2, _)) = eval.apply(HelloWorldIvyDeps.moduleB.runClasspath)
+      assert(
+        result2.exists(_.path.last == "sourcecode_2.12-0.1.4.jar"),
+        !result2.exists(_.path.last == "sourcecode_2.12-0.1.3.jar")
+      )
+    }
   }