add exclusions and custom configuration to dependencies (#254)

* doc to address #187 and #246

* add exclusions and custom configuration to dependencies and tests

3 files changed, 87 insertions, 3 deletions

diff --git a/scalalib/test/src/mill/scalalib/ResolveDepsTests.scala b/scalalib/test/src/mill/scalalib/ResolveDepsTests.scala
index e9734557..b1fcec3e 100644
--- a/scalalib/test/src/mill/scalalib/ResolveDepsTests.scala
+++ b/scalalib/test/src/mill/scalalib/ResolveDepsTests.scala
@@ -26,6 +26,24 @@ object ResolveDepsTests extends TestSuite {
       assert(paths.items.next.path.toString.contains("natives-macos"))
     }
 
+    'excludeTransitiveDeps - {
+      val deps = Agg(ivy"com.lihaoyi::pprint:0.5.3".exclude("com.lihaoyi" -> "fansi_2.12"))
+      val Success(paths) = evalDeps(deps)
+      assert(!paths.exists(_.path.toString.contains("fansi_2.12")))
+    }
+
+    'excludeTransitiveDepsByOrg - {
+      val deps = Agg(ivy"com.lihaoyi::pprint:0.5.3".excludeOrg("com.lihaoyi"))
+      val Success(paths) = evalDeps(deps)
+      assert(!paths.exists(path => path.path.toString.contains("com/lihaoyi") && !path.path.toString.contains("pprint_2.12")))
+    }
+
+    'excludeTransitiveDepsByName - {
+      val deps = Agg(ivy"com.lihaoyi::pprint:0.5.3".excludeName("fansi_2.12"))
+      val Success(paths) = evalDeps(deps)
+      assert(!paths.exists(_.path.toString.contains("fansi_2.12")))
+    }
+
     'errOnInvalidOrgDeps - {
       val deps = Agg(ivy"xxx.yyy.invalid::pprint:0.5.3")
       val Failure(errMsg, _) = evalDeps(deps)
diff --git a/scalalib/test/src/mill/scalalib/publish/IvyTests.scala b/scalalib/test/src/mill/scalalib/publish/IvyTests.scala
new file mode 100644
index 00000000..0f275dd9
--- /dev/null
+++ b/scalalib/test/src/mill/scalalib/publish/IvyTests.scala
@@ -0,0 +1,60 @@
+package mill.scalalib.publish
+
+import utest._
+import mill._
+
+import scala.xml.{Node, NodeSeq, XML}
+
+object IvyTests extends TestSuite {
+
+  def tests: Tests = Tests {
+    val artifactId = "mill-scalalib_2.12"
+    val artifact =
+      Artifact("com.lihaoyi", "mill-scalalib_2.12", "0.0.1")
+    val deps = Agg(
+      Dependency(Artifact("com.lihaoyi", "mill-main_2.12", "0.1.4"),
+        Scope.Compile),
+      Dependency(Artifact("org.scala-sbt", "test-interface", "1.0"),
+        Scope.Compile),
+      Dependency(Artifact("com.lihaoyi", "pprint_2.12", "0.5.3"),
+        Scope.Compile, exclusions = List("com.lihaoyi" -> "fansi_2.12", "*" -> "sourcecode_2.12"))
+    )
+
+    'fullIvy - {
+      val fullIvy = XML.loadString(Ivy(artifact, deps))
+
+      'topLevel - {
+        val info = singleNode(fullIvy \ "info")
+        assert(
+          singleAttr(info, "organisation") == artifact.group
+        , singleAttr(info, "module") == artifact.id
+        , singleAttr(info, "revision") == artifact.version
+        )
+      }
+
+      'dependencies - {
+        val dependencies = fullIvy \ "dependencies" \ "dependency"
+        val ivyDeps = deps.indexed
+
+        assert(dependencies.size == ivyDeps.size)
+
+        dependencies.zipWithIndex.foreach { case (dep, index) =>
+          assert(
+            singleAttr(dep, "org") == ivyDeps(index).artifact.group
+          , singleAttr(dep, "name") == ivyDeps(index).artifact.id
+          , singleAttr(dep, "rev") == ivyDeps(index).artifact.version
+          , (dep \ "exclude").zipWithIndex forall { case (exclude, j) =>
+              singleAttr(exclude, "org") == ivyDeps(index).exclusions(j)._1 &&
+                singleAttr(exclude, "name") == ivyDeps(index).exclusions(j)._2
+            }
+          )
+        }
+      }
+    }
+  }
+
+  def singleNode(seq: NodeSeq): Node =
+    seq.headOption.getOrElse(throw new RuntimeException("empty seq"))
+  def singleAttr(node: Node, attr: String): String =
+    node.attribute(attr).flatMap(_.headOption.map(_.text)).getOrElse(throw new RuntimeException(s"empty attr $attr"))
+}
diff --git a/scalalib/test/src/mill/scalalib/publish/PomTests.scala b/scalalib/test/src/mill/scalalib/publish/PomTests.scala
index 31e87446..c15ff172 100644
--- a/scalalib/test/src/mill/scalalib/publish/PomTests.scala
+++ b/scalalib/test/src/mill/scalalib/publish/PomTests.scala
@@ -15,7 +15,9 @@ object PomTests extends TestSuite {
       Dependency(Artifact("com.lihaoyi", "mill-main_2.12", "0.1.4"),
                  Scope.Compile),
       Dependency(Artifact("org.scala-sbt", "test-interface", "1.0"),
-                 Scope.Compile)
+                 Scope.Compile),
+      Dependency(Artifact("com.lihaoyi", "pprint_2.12", "0.5.3"),
+                 Scope.Compile, exclusions = List("com.lihaoyi" -> "fansi_2.12", "*" -> "sourcecode_2.12"))
     )
     val settings = PomSettings(
       description = "mill-scalalib",
@@ -104,7 +106,7 @@ object PomTests extends TestSuite {
       'dependencies - {
         val dependencies = fullPom \ "dependencies" \ "dependency"
 
-        assert(dependencies.size == 2)
+        assert(dependencies.size == 3)
 
         val pomDeps = deps.indexed
 
@@ -114,7 +116,11 @@ object PomTests extends TestSuite {
               singleText(dep \ "groupId") == pomDeps(index).artifact.group,
               singleText(dep \ "artifactId") == pomDeps(index).artifact.id,
               singleText(dep \ "version") == pomDeps(index).artifact.version,
-              optText(dep \ "scope").isEmpty
+              optText(dep \ "scope").isEmpty,
+              (dep \ "exclusions").zipWithIndex.forall { case (node, j) =>
+                singleText(node \ "exclude" \ "groupId") == pomDeps(index).exclusions(j)._1 &&
+                  singleText(node \ "exclude" \ "artifactId") == pomDeps(index).exclusions(j)._2
+              }
             )
         }
       }