diff options
author | Gregory Nutt <gnutt@nuttx.org> | 2014-05-10 11:36:20 -0600 |
---|---|---|
committer | Gregory Nutt <gnutt@nuttx.org> | 2014-05-10 11:36:20 -0600 |
commit | c5614e5b45fd99eb92ae7807f2132c956ff70147 (patch) | |
tree | 85ee2880657de81a9cd866f1cac9ba6ede3ce9ec | |
parent | 3e75c2da3aa372c71e2543f00c50d8d3abb6002e (diff) | |
download | nuttx-c5614e5b45fd99eb92ae7807f2132c956ff70147.tar.gz nuttx-c5614e5b45fd99eb92ae7807f2132c956ff70147.tar.bz2 nuttx-c5614e5b45fd99eb92ae7807f2132c956ff70147.zip |
Updated README and comments
-rw-r--r-- | nuttx/arch/arm/src/stm32/stm32_i2c.c | 18 | ||||
-rw-r--r-- | nuttx/binfmt/libpcode/README.txt | 11 |
2 files changed, 20 insertions, 9 deletions
diff --git a/nuttx/arch/arm/src/stm32/stm32_i2c.c b/nuttx/arch/arm/src/stm32/stm32_i2c.c index d745261a7..7be312a9c 100644 --- a/nuttx/arch/arm/src/stm32/stm32_i2c.c +++ b/nuttx/arch/arm/src/stm32/stm32_i2c.c @@ -1125,6 +1125,7 @@ static inline uint32_t stm32_i2c_disablefsmc(FAR struct stm32_i2c_priv_s *priv) regval = ret & ~RCC_AHBENR_FSMCEN; putreg32(regval, STM32_RCC_AHBENR); } + return ret; } @@ -1581,7 +1582,8 @@ static int stm32_i2c_setaddress(FAR struct i2c_dev_s *dev, int addr, int nbits) * ************************************************************************************/ -static int stm32_i2c_process(FAR struct i2c_dev_s *dev, FAR struct i2c_msg_s *msgs, int count) +static int stm32_i2c_process(FAR struct i2c_dev_s *dev, FAR struct i2c_msg_s *msgs, + int count) { struct stm32_i2c_inst_s *inst = (struct stm32_i2c_inst_s *)dev; FAR struct stm32_i2c_priv_s *priv = inst->priv; @@ -1828,14 +1830,14 @@ static int stm32_i2c_writeread(FAR struct i2c_dev_s *dev, const uint8_t *wbuffer, int wbuflen, uint8_t *buffer, int buflen) { - stm32_i2c_sem_wait(dev); /* ensure that address or flags don't change meanwhile */ + stm32_i2c_sem_wait(dev); /* Ensure that address or flags don't change meanwhile */ struct i2c_msg_s msgv[2] = { { .addr = ((struct stm32_i2c_inst_s *)dev)->address, .flags = ((struct stm32_i2c_inst_s *)dev)->flags, - .buffer = (uint8_t *)wbuffer, /* this is really ugly, sorry const ... */ + .buffer = (uint8_t *)wbuffer, /* This is really ugly, sorry const ... */ .length = wbuflen }, { @@ -1862,7 +1864,7 @@ static int stm32_i2c_writeread(FAR struct i2c_dev_s *dev, static int stm32_i2c_transfer(FAR struct i2c_dev_s *dev, FAR struct i2c_msg_s *msgs, int count) { - stm32_i2c_sem_wait(dev); /* ensure that address or flags don't change meanwhile */ + stm32_i2c_sem_wait(dev); /* Ensure that address or flags don't change meanwhile */ return stm32_i2c_process(dev, msgs, count); } #endif @@ -1881,8 +1883,8 @@ static int stm32_i2c_transfer(FAR struct i2c_dev_s *dev, FAR struct i2c_msg_s *m FAR struct i2c_dev_s *up_i2cinitialize(int port) { - struct stm32_i2c_priv_s * priv = NULL; /* private data of device with multiple instances */ - struct stm32_i2c_inst_s * inst = NULL; /* device, single instance */ + struct stm32_i2c_priv_s * priv = NULL; /* Private data of device with multiple instances */ + struct stm32_i2c_inst_s * inst = NULL; /* Eevice, single instance */ int irqs; #if STM32_PCLK1_FREQUENCY < 4000000 @@ -1932,7 +1934,7 @@ FAR struct i2c_dev_s *up_i2cinitialize(int port) inst->address = 0; inst->flags = 0; - /* Init private data for the first time, increment refs count, + /* Initialize private data for the first time, increment reference count, * power-up hardware and configure GPIOs. */ @@ -1962,7 +1964,7 @@ int up_i2cuninitialize(FAR struct i2c_dev_s * dev) ASSERT(dev); - /* Decrement refs and check for underflow */ + /* Decrement reference count and check for underflow */ if (((struct stm32_i2c_inst_s *)dev)->priv->refs == 0) { diff --git a/nuttx/binfmt/libpcode/README.txt b/nuttx/binfmt/libpcode/README.txt index d8fcc7f32..05e5575e8 100644 --- a/nuttx/binfmt/libpcode/README.txt +++ b/nuttx/binfmt/libpcode/README.txt @@ -150,7 +150,16 @@ The general idea to fix both of these problems is as follows: on the command line. This might be accomplished by simply modifying the argv[] structure in the struct binary_s instance. + The current start-up logic in binfmt_execmodule.c would have modified to + handle this special start-up. Perhaps the struct binfmt_s could be + extended to include an exec() method that provides custom start up logic? + 4. Add a task start hook to the program. Here is where we can setup up the on_exit() function that will clean up after the P-Code program terminates. -There are many other smaller issues to be resolved, but those are the main ones. +There are many other smaller issues to be resolved, but those are the main +ones. + +A more complex solution might include a user-space p-code daemon that +receives the P-Code path in a POSIX message and starts a P-Code interpreter +thread wholly in user space. |