There used to be two ways to pass parameters to new tasks, depending upon the configuration: Either (1) argv[] as created as an array with each string strdup'ed. Or (1) argv[] array and strings were created on the stack before the new task was started. Now, there is only one way, way (1). Way (2) might be slightly more compact, but this is not worth carry the complexity of two different ways of doing the same thing.

5 files changed, 31 insertions, 28 deletions

diff --git a/nuttx/arch/z80/src/common/up_stackframe.c b/nuttx/arch/z80/src/common/up_stackframe.c
index 1db0bf470..2c419c723 100644
--- a/nuttx/arch/z80/src/common/up_stackframe.c
+++ b/nuttx/arch/z80/src/common/up_stackframe.c
@@ -136,3 +136,4 @@ FAR void *up_stack_frame(FAR struct tcb_s *tcb, size_t frame_size)
 
   return (FAR void *)(topaddr + sizeof(uint32_t));
 }
+
diff --git a/nuttx/arch/z80/src/ez80/Make.defs b/nuttx/arch/z80/src/ez80/Make.defs
index 3ce0b4c42..4dbeed0f3 100644
--- a/nuttx/arch/z80/src/ez80/Make.defs
+++ b/nuttx/arch/z80/src/ez80/Make.defs
@@ -36,15 +36,16 @@
 HEAD_ASRC = ez80_vectors.asm
 HEAD_SSRC =
 
-CMN_SSRCS =
-CMN_CSRCS = up_initialize.c up_allocateheap.c up_createstack.c \
-		  up_releasestack.c up_interruptcontext.c up_blocktask.c \
-		  up_unblocktask.c up_exit.c up_releasepending.c \
-		  up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c \
-		  up_mdelay.c up_udelay.c up_usestack.c up_puts.c
+CMN_SSRCS  =
+CMN_CSRCS  = up_initialize.c up_allocateheap.c up_createstack.c
+CMN_CSRCS += up_releasestack.c up_interruptcontext.c up_blocktask.c
+CMN_CSRCS += up_unblocktask.c up_exit.c up_releasepending.c
+CMN_CSRCS += up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c
+CMN_CSRCS += up_mdelay.c up_stackframe.c up_udelay.c up_usestack.c
+CMN_CSRCS += up_puts.c
 
-CHIP_ASRCS = ez80_startup.asm ez80_io.asm ez80_irqsave.asm \
-		  ez80_saveusercontext.asm ez80_restorecontext.asm
+CHIP_ASRCS = ez80_startup.asm ez80_io.asm ez80_irqsave.asm
+  ez80_saveusercontext.asm ez80_restorecontext.asm
 ifeq ($(CONFIG_ARCH_CHIP_EZ80F91),y)
 CHIP_ASRCS += ez80f91_init.asm
 endif
diff --git a/nuttx/arch/z80/src/z180/Make.defs b/nuttx/arch/z80/src/z180/Make.defs
index 3e8c4b7f4..0f71bb949 100644
--- a/nuttx/arch/z80/src/z180/Make.defs
+++ b/nuttx/arch/z80/src/z180/Make.defs
@@ -45,8 +45,8 @@ CMN_ASRCS  =
 CMN_CSRCS  = up_allocateheap.c up_assert.c up_blocktask.c up_createstack.c
 CMN_CSRCS += up_doirq.c up_exit.c up_idle.c up_initialize.c
 CMN_CSRCS += up_interruptcontext.c up_mdelay.c up_releasepending.c
-CMN_CSRCS += up_releasestack.c up_reprioritizertr.c up_unblocktask.c
-CMN_CSRCS += up_udelay.c up_usestack.c
+CMN_CSRCS += up_releasestack.c up_stackframe.c up_reprioritizertr.c
+CMN_CSRCS += up_unblocktask.c up_udelay.c up_usestack.c
 
 CHIP_ASRCS  = z180_restoreusercontext.asm z180_saveusercontext.asm
 CHIP_ASRCS += z180_vectcommon.asm
diff --git a/nuttx/arch/z80/src/z8/Make.defs b/nuttx/arch/z80/src/z8/Make.defs
index 50f1d98b0..7a7476aa4 100644
--- a/nuttx/arch/z80/src/z8/Make.defs
+++ b/nuttx/arch/z80/src/z8/Make.defs
@@ -35,12 +35,12 @@
 
 HEAD_SSRC = z8_head.S
 
-CMN_SSRCS =
-CMN_CSRCS = up_initialize.c up_allocateheap.c up_createstack.c \
-		  up_releasestack.c up_interruptcontext.c up_blocktask.c \
-		  up_unblocktask.c up_exit.c up_releasepending.c \
-		  up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c \
-		  up_mdelay.c up_udelay.c up_usestack.c
+CMN_SSRCS  =
+CMN_CSRCS  = up_initialize.c up_allocateheap.c up_createstack.c
+CMN_CSRCS += up_releasestack.c up_interruptcontext.c up_blocktask.c
+CMN_CSRCS += up_unblocktask.c up_exit.c up_releasepending.c
+CMN_CSRCS += up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c
+CMN_CSRCS += up_mdelay.c up_stackframe.c up_udelay.c up_usestack.c
 
 CHIP_SSRCS  = z8_vector.S z8_saveusercontext.S z8_restorecontext.S
 CHIP_CSRCS  = z8_initialstate.c z8_irq.c z8_saveirqcontext.c
diff --git a/nuttx/arch/z80/src/z80/Make.defs b/nuttx/arch/z80/src/z80/Make.defs
index c60e88be6..485dc3bbc 100644
--- a/nuttx/arch/z80/src/z80/Make.defs
+++ b/nuttx/arch/z80/src/z80/Make.defs
@@ -35,21 +35,22 @@
 
 ifeq ($(CONFIG_ARCH_HAVEHEAD),)
 ifeq ($(CONFIG_LINKER_ROM_AT_0000),y)
-HEAD_ASRC	= z80_rom.asm
+HEAD_ASRC = z80_rom.asm
 else
-HEAD_ASRC	= z80_head.asm
+HEAD_ASRC = z80_head.asm
 endif
 endif
 
-CMN_ASRCS	=
-CMN_CSRCS	= up_initialize.c up_allocateheap.c up_createstack.c \
-		  up_releasestack.c up_interruptcontext.c up_blocktask.c  \
-		  up_unblocktask.c up_exit.c up_releasepending.c \
-		  up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c \
-		  up_mdelay.c up_udelay.c up_usestack.c
+CMN_ASRCS  =
 
-CHIP_ASRCS	= z80_saveusercontext.asm z80_restoreusercontext.asm
-CHIP_CSRCS	= z80_initialstate.c z80_io.c z80_irq.c z80_copystate.c \
-		  z80_schedulesigaction.c z80_sigdeliver.c \
-		  z80_registerdump.c
+CMN_CSRCS  = up_initialize.c up_allocateheap.c up_createstack.c
+CMN_CSRCS += up_releasestack.c up_interruptcontext.c up_blocktask.c
+CMN_CSRCS += up_unblocktask.c up_exit.c up_releasepending.c
+CMN_CSRCS += up_reprioritizertr.c up_idle.c up_assert.c up_doirq.c
+CMN_CSRCS += up_mdelay.c up_stackframe.c up_udelay.c up_usestack.c
 
+CHIP_ASRCS  = z80_saveusercontext.asm z80_restoreusercontext.asm
+
+CHIP_CSRCS  = z80_initialstate.c z80_io.c z80_irq.c z80_copystate.c
+CHIP_CSRCS += z80_schedulesigaction.c z80_sigdeliver.c
+CHIP_CSRCS += z80_registerdump.c