diff options
| author | Fahrzin Hemmati <fahhem@users.noreply.github.com> | 2017-11-28 14:24:53 -0800 |
|---|---|---|
| committer | Fahrzin Hemmati <fahhem@appliedintuition.com> | 2017-12-04 15:12:08 -0800 |
| commit | 35119e39a07f426f3c48a1bfb41d862994223742 (patch) | |
| tree | 88a83f067a1de2ba58ff7543801a50fd959d2ef1 | |
| parent | 6de51caed52d798815954646b230c5aef3e4d2fc (diff) | |
| download | protobuf-35119e39a07f426f3c48a1bfb41d862994223742.tar.gz protobuf-35119e39a07f426f3c48a1bfb41d862994223742.tar.bz2 protobuf-35119e39a07f426f3c48a1bfb41d862994223742.zip | |
Add a check_protobuf_required_bazel_version() for use in WORKSPACEs
| -rw-r--r-- | examples/WORKSPACE | 2 | ||||
| -rw-r--r-- | protobuf.bzl | 12 |
2 files changed, 14 insertions, 0 deletions
diff --git a/examples/WORKSPACE b/examples/WORKSPACE index bb003107..936f2441 100644 --- a/examples/WORKSPACE +++ b/examples/WORKSPACE @@ -5,6 +5,8 @@ http_archive( strip_prefix = "protobuf-master", urls = ["https://github.com/google/protobuf/archive/master.zip"], ) +load("@com_google_protobuf//:protobuf.bzl", "check_protobuf_required_bazel_version") +check_protobuf_required_bazel_version() # This com_google_protobuf_cc repository is required for cc_proto_library # rule. It provides protobuf C++ runtime. Note that it actually is the same diff --git a/protobuf.bzl b/protobuf.bzl index 23380bab..6aed44a4 100644 --- a/protobuf.bzl +++ b/protobuf.bzl @@ -400,3 +400,15 @@ def internal_protobuf_py_tests( srcs=[s], main=s, **kargs) + + +def check_protobuf_required_bazel_version(): + """For WORKSPACE files, to check the installed version of bazel. + + This ensures bazel supports our approach to proto_library() depending on a + copied filegroup. (Fixed in bazel 0.5.4) + """ + expected = apple_common.dotted_version("0.5.4") + current = apple_common.dotted_version(native.bazel_version) + if current.compare_to(expected) < 0: + fail("Bazel must be newer than 0.5.4") |