diff options
| author | jasonh+personal@google.com <jasonh+personal@google.com@630680e5-0e50-0410-840e-4b1c322b438d> | 2009-12-01 18:05:21 +0000 |
|---|---|---|
| committer | jasonh+personal@google.com <jasonh+personal@google.com@630680e5-0e50-0410-840e-4b1c322b438d> | 2009-12-01 18:05:21 +0000 |
| commit | 9951233e9a5c23ad285b0286e7e896bfd46f8397 (patch) | |
| tree | 08ea80c9fb0fe98c5011143f5123cab37e9cd364 /COPYING.txt | |
| parent | 6493368285ce77792f6076954d4311a9a457a826 (diff) | |
| download | protobuf-9951233e9a5c23ad285b0286e7e896bfd46f8397.tar.gz protobuf-9951233e9a5c23ad285b0286e7e896bfd46f8397.tar.bz2 protobuf-9951233e9a5c23ad285b0286e7e896bfd46f8397.zip | |
Fix Issue 136: the memoized serialized size for packed fields may not
be properly set. writeTo() may be invoked without a call to
getSerializedSize(), so the generated serialization methods would
write a length of 0 for non-empty packed fields. Just call
getSerializedSize() at the beginning of writeTo(): although this
means that we may compute the byte size needlessly when there
are no packed fields, in practice, getSerializedSize() will
already have been called - all of the writeTo() wrappers in
AbstractMessageLite invoke it.
Tested: new unittest case in WireFormatTest.java now passes
Diffstat (limited to 'COPYING.txt')
0 files changed, 0 insertions, 0 deletions