aboutsummaryrefslogtreecommitdiff
path: root/java
diff options
context:
space:
mode:
authorFeng Xiao <xfxyjwf@gmail.com>2014-12-10 20:56:13 -0800
committerFeng Xiao <xfxyjwf@gmail.com>2014-12-10 20:56:13 -0800
commit52909485d15a9ac617bc8948c02dafd1ab4233bd (patch)
treeb0d60d94523b828c077bfe47f30ce0e70c01f267 /java
parent261fe97a63316a4a4918afcaa6c8c0f4b0da45fc (diff)
parent8d5d7cc6d03b00fcb7162525100fbd4cc0d1929d (diff)
downloadprotobuf-52909485d15a9ac617bc8948c02dafd1ab4233bd.tar.gz
protobuf-52909485d15a9ac617bc8948c02dafd1ab4233bd.tar.bz2
protobuf-52909485d15a9ac617bc8948c02dafd1ab4233bd.zip
Merge branch v3.0.0-alpha-1 into master.
Conflicts: configure.ac
Diffstat (limited to 'java')
-rw-r--r--java/pom.xml4
-rw-r--r--java/src/main/java/com/google/protobuf/MapFieldLite.java2
-rw-r--r--java/src/test/java/com/google/protobuf/MapTest.java7
-rw-r--r--java/src/test/java/com/google/protobuf/UnknownFieldSetLiteTest.java5
4 files changed, 12 insertions, 6 deletions
diff --git a/java/pom.xml b/java/pom.xml
index 4ec6d776..bc339f66 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -10,7 +10,7 @@
</parent>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
- <version>2.6.2-pre</version>
+ <version>3.0.0-alpha-1</version>
<packaging>bundle</packaging>
<name>Protocol Buffer Java API</name>
<description>
@@ -152,7 +152,7 @@
<instructions>
<Bundle-DocURL>https://developers.google.com/protocol-buffers/</Bundle-DocURL>
<Bundle-SymbolicName>com.google.protobuf</Bundle-SymbolicName>
- <Export-Package>com.google.protobuf;version=2.6.2-pre</Export-Package>
+ <Export-Package>com.google.protobuf;version=3.0.0-alpha-1</Export-Package>
</instructions>
</configuration>
</plugin>
diff --git a/java/src/main/java/com/google/protobuf/MapFieldLite.java b/java/src/main/java/com/google/protobuf/MapFieldLite.java
index eea36d9e..7f94c690 100644
--- a/java/src/main/java/com/google/protobuf/MapFieldLite.java
+++ b/java/src/main/java/com/google/protobuf/MapFieldLite.java
@@ -97,7 +97,7 @@ public class MapFieldLite<K, V> {
if (a == b) {
return true;
}
- if (a.size() != a.size()) {
+ if (a.size() != b.size()) {
return false;
}
for (Map.Entry<K, V> entry : a.entrySet()) {
diff --git a/java/src/test/java/com/google/protobuf/MapTest.java b/java/src/test/java/com/google/protobuf/MapTest.java
index 542a20e7..9a25e302 100644
--- a/java/src/test/java/com/google/protobuf/MapTest.java
+++ b/java/src/test/java/com/google/protobuf/MapTest.java
@@ -260,6 +260,13 @@ public class MapTest extends TestCase {
assertFalse(m1.equals(m2));
// Don't check m1.hashCode() != m2.hashCode() because it's not guaranteed
// to be different.
+
+ // Regression test for b/18549190: if a map is a subset of the other map,
+ // equals() should return false.
+ b2.getMutableInt32ToInt32Field().remove(1);
+ m2 = b2.build();
+ assertFalse(m1.equals(m2));
+ assertFalse(m2.equals(m1));
}
diff --git a/java/src/test/java/com/google/protobuf/UnknownFieldSetLiteTest.java b/java/src/test/java/com/google/protobuf/UnknownFieldSetLiteTest.java
index 6372b7a7..cec3da1e 100644
--- a/java/src/test/java/com/google/protobuf/UnknownFieldSetLiteTest.java
+++ b/java/src/test/java/com/google/protobuf/UnknownFieldSetLiteTest.java
@@ -38,7 +38,6 @@ import junit.framework.TestCase;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
-import java.nio.charset.StandardCharsets;
/**
* Tests for {@link UnknownFieldSetLite}.
@@ -228,9 +227,9 @@ public class UnknownFieldSetLiteTest extends TestCase {
assertEquals(foo, copyOfCopy);
}
- public void testMalformedBytes() {
+ public void testMalformedBytes() throws Exception {
try {
- Foo.parseFrom("this is a malformed protocol buffer".getBytes(StandardCharsets.UTF_8));
+ Foo.parseFrom("this is a malformed protocol buffer".getBytes("UTF-8"));
fail();
} catch (InvalidProtocolBufferException e) {
// Expected.