diff options
| author | Paul Yang <TeBoring@users.noreply.github.com> | 2017-10-09 12:39:13 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-09 12:39:13 -0700 |
| commit | 6032746882ea48ff6d983df8cb77e2ebf399bf0c (patch) | |
| tree | 700ba1d858ea0365401b639bd7ef613c90c89743 /php/ext/google/protobuf/message.c | |
| parent | 77f64bb7779ec2195f9bc4dc82497d12c18fc6b7 (diff) | |
| download | protobuf-6032746882ea48ff6d983df8cb77e2ebf399bf0c.tar.gz protobuf-6032746882ea48ff6d983df8cb77e2ebf399bf0c.tar.bz2 protobuf-6032746882ea48ff6d983df8cb77e2ebf399bf0c.zip | |
Reserve unknown fields in php (#3659)
* Reserve unknown fields in upb
1) For decoding, an unknownfields will be lazily created on message,
which contains bytes of unknown fields.
2) For encoding, if the unknownfields is present on message, all bytes
contained in it will be serialized.
* Register the function to encode unknown field at decode time.
* Remove upb_handlers_setaddunknown
* Use upb_sink_putunknown in decoder
* Remove upb_pb_encoder_encode_unknown
* Do not expose encode_unknown
* Implement reserve unknown field in php Implement.
* Make buffer private to CodedInputStream
Diffstat (limited to 'php/ext/google/protobuf/message.c')
| -rw-r--r-- | php/ext/google/protobuf/message.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/php/ext/google/protobuf/message.c b/php/ext/google/protobuf/message.c index 6ebf1b9d..291f5c24 100644 --- a/php/ext/google/protobuf/message.c +++ b/php/ext/google/protobuf/message.c @@ -81,6 +81,10 @@ static HashTable* message_get_properties(zval* object TSRMLS_DC); // Define object free method. PHP_PROTO_OBJECT_FREE_START(MessageHeader, message) + if (*(void**)intern->data != NULL) { + stringsink_uninit(*(void**)intern->data); + FREE(*(void**)intern->data); + } FREE(intern->data); PHP_PROTO_OBJECT_FREE_END |