diff options
| author | Feng Xiao <xfxyjwf@gmail.com> | 2018-06-22 17:47:17 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-06-22 17:47:17 -0700 |
| commit | 91707246ebc579bf573ef033f3aa87a98c933d06 (patch) | |
| tree | 8e4784e4ae1c7c18ae45bc95549534ead8ddd131 /protobuf.bzl | |
| parent | f42d5923f0b6de75611af0a8c8b3354763aece00 (diff) | |
| parent | b2a190832cb66230e128c476a86c4ba9aa6c479f (diff) | |
| download | protobuf-91707246ebc579bf573ef033f3aa87a98c933d06.tar.gz protobuf-91707246ebc579bf573ef033f3aa87a98c933d06.tar.bz2 protobuf-91707246ebc579bf573ef033f3aa87a98c933d06.zip | |
Merge pull request #4168 from jin/master
Use versions module from Skylib for version checking
Diffstat (limited to 'protobuf.bzl')
| -rw-r--r-- | protobuf.bzl | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/protobuf.bzl b/protobuf.bzl index 4226a142..8bbd0564 100644 --- a/protobuf.bzl +++ b/protobuf.bzl @@ -1,3 +1,5 @@ +load("@bazel_skylib//:lib.bzl", "versions") + def _GetPath(ctx, path): if ctx.label.workspace_root: return ctx.label.workspace_root + '/' + path @@ -411,7 +413,4 @@ def check_protobuf_required_bazel_version(): This ensures bazel supports our approach to proto_library() depending on a copied filegroup. (Fixed in bazel 0.5.4) """ - expected = apple_common.dotted_version("0.5.4") - current = apple_common.dotted_version(native.bazel_version) - if current.compare_to(expected) < 0: - fail("Bazel must be newer than 0.5.4") + versions.check(minimum_bazel_version = "0.5.4") |