aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJon Skeet <jonskeet@google.com>2015-08-07 13:43:05 +0100
committerJon Skeet <jonskeet@google.com>2015-08-07 13:45:56 +0100
commit93bdf36f8b0ce94ebde3fb12e4b8dcaead6b8164 (patch)
tree362bdf46fbb4c608dc1a41864c66f7628cd17f38 /src
parentb76b76ba4f5152550fd334a6f3533d4db208f633 (diff)
downloadprotobuf-93bdf36f8b0ce94ebde3fb12e4b8dcaead6b8164.tar.gz
protobuf-93bdf36f8b0ce94ebde3fb12e4b8dcaead6b8164.tar.bz2
protobuf-93bdf36f8b0ce94ebde3fb12e4b8dcaead6b8164.zip
Remove our own version of MakeTag now that the main one is fixed.
"Tested" by regenerating code and observing that there are no changes.
Diffstat (limited to 'src')
-rw-r--r--src/google/protobuf/compiler/csharp/csharp_field_base.cc2
-rw-r--r--src/google/protobuf/compiler/csharp/csharp_helpers.cc11
2 files changed, 1 insertions, 12 deletions
diff --git a/src/google/protobuf/compiler/csharp/csharp_field_base.cc b/src/google/protobuf/compiler/csharp/csharp_field_base.cc
index 7e3bbeef..cd29bcf9 100644
--- a/src/google/protobuf/compiler/csharp/csharp_field_base.cc
+++ b/src/google/protobuf/compiler/csharp/csharp_field_base.cc
@@ -59,7 +59,7 @@ void FieldGeneratorBase::SetCommonFieldVariables(
// repeated fields varies by wire format. The wire format is encoded in the bottom 3 bits, which
// never effects the tag size.
int tag_size = internal::WireFormat::TagSize(descriptor_->number(), descriptor_->type());
- uint tag = FixedMakeTag(descriptor_);
+ uint tag = internal::WireFormat::MakeTag(descriptor_);
uint8 tag_array[5];
io::CodedOutputStream::WriteTagToArray(tag, tag_array);
string tag_bytes = SimpleItoa(tag_array[0]);
diff --git a/src/google/protobuf/compiler/csharp/csharp_helpers.cc b/src/google/protobuf/compiler/csharp/csharp_helpers.cc
index 46f4fc33..d25dcba9 100644
--- a/src/google/protobuf/compiler/csharp/csharp_helpers.cc
+++ b/src/google/protobuf/compiler/csharp/csharp_helpers.cc
@@ -338,17 +338,6 @@ std::string FileDescriptorToBase64(const FileDescriptor* descriptor) {
return StringToBase64(fdp_bytes);
}
-// TODO(jonskeet): Remove this when internal::WireFormat::MakeTag works
-// properly...
-// Workaround for issue #493
-uint FixedMakeTag(const FieldDescriptor* field) {
- internal::WireFormatLite::WireType field_type = field->is_packed()
- ? internal::WireFormatLite::WIRETYPE_LENGTH_DELIMITED
- : internal::WireFormat::WireTypeForFieldType(field->type());
-
- return internal::WireFormatLite::MakeTag(field->number(), field_type);
-}
-
FieldGeneratorBase* CreateFieldGenerator(const FieldDescriptor* descriptor,
int fieldOrdinal) {
switch (descriptor->type()) {